-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use packaged bats in Fedora, side-load for Ubuntu #140
Conversation
Crossing my fingers and hoping this works (it may be slightly over-complicated) 😜 |
okay ya, this is way too complex of a change (even though it appears to be working). I'm going to push up a vastly simpler version once these images finish building. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, you're right, that was a lot more than I'd expected :)
Two concerns (not blockers, but more than nits). And a caveat that much of this (the gce.yml) is way above my head. But, yeah, LGTM. Thanks for the quick work.
641d05a
to
c619511
Compare
I've stripped that out and vastly simplified things. Then I went and screwed up again by including a commit I should just make a separate PR for. Sigh...there's always time for another try... |
c619511
to
a18a32e
Compare
...alright, fingers crossed. |
First-in example of this working (container-build): https://cirrus-ci.com/task/6558019998711808?logs=main#L2496 Farther down the logs the one from podman
I expect to get the same result when the VM builds happen. |
The 'ubuntu Cache Image' build failure seems to be an upstream problem:
At least for libsystemd-dev, it's reported here. I'm assuming once this is fixed, the libudev1 package will get fixed as well. |
Cirrus CI build successful. Image ID |
Passed on re-run. I still haven't done a final review, but in my first passes (on earlier revisions) all seemed fine. |
Oh, thanks a bunch for re-running that! So it was def. a hangup in the upstream repos. Anyway, no rush to review, I can get a PR going in podman to test the new image (and remove the |
Podman PR: containers/podman#14719 |
Ref: containers/automation_images#140 Signed-off-by: Chris Evich <[email protected]>
Buildah PR: containers/buildah#4074 |
Rebuilding images due to problems with podman package in Ubuntu. |
Fixes containers#139 N/B: Using these images requires an update to the podman repo. to remove the bats installer script and `Makefile` target. Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
7c0b9cd
to
98b5d75
Compare
Cirrus CI build successful. Image ID |
Ref: containers/automation_images#140 Signed-off-by: Chris Evich <[email protected]>
Ref: containers/automation_images#140 and containers/automation_images#149 Signed-off-by: Chris Evich <[email protected]>
Note: Fedora-35 is disabled due to missing golang 1.18 Ref: containers/automation_images#140 and containers/automation_images#149 and containers/automation_images#146 Signed-off-by: Chris Evich <[email protected]>
Note: Fedora-35 is disabled due to missing golang 1.18 Ref: containers/automation_images#140 and containers/automation_images#149 and containers/automation_images#146 Signed-off-by: Chris Evich <[email protected]>
Note: Fedora-35 is disabled due to missing golang 1.18 Ref: containers/automation_images#140 and containers/automation_images#149 and containers/automation_images#146 Signed-off-by: Chris Evich <[email protected]>
Fixes #139
N/B: Using these images requires an update to the podman repo. to remove
the bats installer script and
Makefile
target.