Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail copy to emptydir - v1.19 #3016

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

TomSweeneyRedHat
Copy link
Member

What type of PR is this?

/kind api-change
/kind bud
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

Cherry pick of #2978

How to verify it

See added tests

Which issue(s) this PR fixes:

#2964

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Copying to an empty directory in a Container during the build process will now work as expected.

Cherrypick #2978 to fix and issue when
copying files to an empty directory on a container.

Signed-off-by: TomSweeneyRedHat <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

@TomSweeneyRedHat: The label(s) kind/bud cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind api-change
/kind bud
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

Cherry pick of #2978

How to verify it

See added tests

Which issue(s) this PR fixes:

#2964

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Copying to an empty directory in a Container during the build process will now work as expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Feb 17, 2021

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 016b90d into release-1.19 Feb 17, 2021
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/emptydir_1.19 branch February 17, 2021 18:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants