Don't fail copy to emptydir

[TomSweeneyRedHat]

When a COPY command was being targeted at an empty new directory,
the copy would fail. It could be "worked around" by putting a dummy
file into the directory.

Fixes: #2964
Signed-off-by: TomSweeneyRedHat [email protected]

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

Fixes an issue where a COPY to a new/empty directory would fail during the build process.

How to verify it

See 'bud test empty newdir' in bud.bats

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

An issue was fixed where a COPY command in a Containerfile would fail if the destination was an empty directory and a file was being placed into it.

[TomSweeneyRedHat]

@nalind PTAL

[TomSweeneyRedHat]

Looks like a legit test failure. Will have to see if the test was wrong to begin with as it was expected to fail but now succeeds or if I messed something up.

[+0202s] not ok 33 bud with .dockerignore
[+0202s] # (from function `die' in file ./helpers.bash, line 196,
[+0202s] #  from function `run_buildah' in file ./helpers.bash, line 183,
[+0202s] #  in test file ./bud.bats, line 20)
[+0202s] #   `run_buildah 125 bud -t testbud --signature-policy ${TESTSDIR}/policy.json -f ${TESTSDIR}/bud/dockerignore/Dockerfile ${TESTSDIR}/bud/dockerignore' failed
```

[TomSweeneyRedHat]

OK, I found the issue. I was not considering the .dockerignore file before doing the empty dir creation in the container. I've moved that logic down under the excludes check and it's now (hopefully) working with the next push.

[rhatdan]

/approve
lgtm

[rhatdan]

@vrothberg @giuseppe @saschagrunert @nalind PTAL

[saschagrunert]

LGTM

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: rhatdan, saschagrunert, TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm