Avoid overriding LDFLAGS in Makefile #2752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
LDFLAGS
is a common/standard variable to hold linker flags for C/C++ compilers.This PR uses a different name (
BUILDAH_LDFLAGS
) for the-ldflags
passed on to Go so that we avoid overridingLDFLAGS
set in the environment.How to verify it
In conjunction with #2751:
If, e.g.,
libdevmapper
is installed at a non-standard path, adding-L/path/to/devmapper/prefix/lib
lets the build find said library -- but only if we don't overrideLDFLAGS
in theMakefile
.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?