Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overriding LDFLAGS in Makefile #2752

Merged

Conversation

mbargull
Copy link
Contributor

@mbargull mbargull commented Nov 6, 2020

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind other

What this PR does / why we need it:

LDFLAGS is a common/standard variable to hold linker flags for C/C++ compilers.
This PR uses a different name (BUILDAH_LDFLAGS) for the -ldflags passed on to Go so that we avoid overriding LDFLAGS set in the environment.

How to verify it

In conjunction with #2751:
If, e.g., libdevmapper is installed at a non-standard path, adding -L/path/to/devmapper/prefix/lib lets the build find said library -- but only if we don't override LDFLAGS in the Makefile.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@rhatdan
Copy link
Member

rhatdan commented Nov 6, 2020

Thanks @mbargull
/approve
LGTM
@TomSweeneyRedHat PTAL
@containers/podman-maintainers PTAL

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbargull, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 0c7eff8 into containers:master Nov 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants