Use CPP, CC and flags in dep check scripts #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2020
|
Thanks @mbargull |
8 tasks
|
Changes LGTM, but this needs a rebase. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbargull, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Marcel Bargull <[email protected]>
mbargull
force-pushed
the
check-scripts-env-cc
branch
from
a2c06b6 to
c219669
Compare
Done. |
|
LGTM |
|
/lgtm |
|
/hold cancel |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
Allow build system without standard
ccto successfully run the dependency checking helper scripts from the Makefile.This supports custom compilers specified by the common
CCenvironment variable, preprocessors given asCPPand additional preprocessor flags fromCPPFLAGS.Additionally, additional flags from
CFLAGSandLDFLAGSare considered for compiling/linking.Overall, this facilitates cross-compilation and similar setups (e.g., for building Conda packages at https://gitub.com/conda-forge).
How to verify it
Temporarily remove
ccfromPATHand pointCC/CPPto a different compiler.Install header files, e.g.,
btrfs/ioctl.h, in a custom location and setCPPFLAGS=-I/custom/location.Add
-Wl,--as-neededtoLDFLAGS(which makes library order important (again) while linking) to confirm the order of the inputs-and-ldevmapperis correct inlibdm_tag.sh.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?