runSetupBuiltinVolumes(): break up volume setup #1126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Break setup for built-in volumes into independent steps where we create the volume's mount point, the directory that will hold its contents, and if there is content under the mount point, populate the volume with the mount point's contents. Signed-off-by: Nalin Dahyabhai <[email protected]>
This was referenced Oct 24, 2018
|
I'm not sure why the 1.11 builds are failing on this PR as the file they're failing on are not part of this PR and pass in other PR's? |
|
Quick review and the code looks good, but I want to test/play with it in the morn. |
|
📌 Commit 61ad9ee has been approved by |
|
⚡ Test exempted: pull fully rebased and already tested. |
There was a problem hiding this comment.
Well after the horse left the barn, but the changes LGTM and the testing is working well with this. Thanks @nalind!
BTB, I've put in a PR to hopefully take care of the unshare.go gofmt problem. I'm still not sure how/why that started popping up, but it's unrelated to this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break setup for built-in volumes into independent steps where we create the volume's mount point, the directory that will hold its contents, and if there is content under the mount point, populate the volume with the mount point's contents.
This should help with #1125.