Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty built in directory #1125

Conversation

TomSweeneyRedHat
Copy link
Member

Signed-off-by: TomSweeneyRedHat [email protected]

For at least the registry:2 image, the volume was existent, but empty:

           "ArgsEscaped": true,
            "Image": "sha256:bc0d86131a2db92f18b8413a38da41718748b152024be47a8bc9413fa1d50a95",
            "Volumes": {
                "/var/lib/registry": {}
            },

The srcPath was never created on disk by the time the stat happened at 514, so the stat failed. I'm not sure if this is the right approach or if we need to somehow create the srcPath, I wasn't able to see away to do that unless we move this functionality outside of this function and do the processing after the directory is created.

Prior to this fix, this would fail:

registry=$(buildah from registry:2)
buildah --debug run $registry -- htpasswd -Bbn testuser testpassword > /root/auth/htpasswd

But if you ran the run command a second time, it would succeed.

Signed-off-by: TomSweeneyRedHat <[email protected]>
@TomSweeneyRedHat
Copy link
Member Author

I'm going to close this one as either #1126 or less likely #1127 will replace it.

@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/builtin branch October 24, 2018 23:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant