Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildah bud params don't match docker build params #599

Closed
TomSweeneyRedHat opened this issue Apr 17, 2018 · 11 comments
Closed

buildah bud params don't match docker build params #599

TomSweeneyRedHat opened this issue Apr 17, 2018 · 11 comments

Comments

@TomSweeneyRedHat
Copy link
Member

Description

The available parameters for buildah bud don't match the ones available for docker build. We need to match them and/or create documentation stating what we don't match.

Reported by @dustymabe

@pixdrift
Copy link
Contributor

pixdrift commented Apr 24, 2018

parameter buildah bud 0.16 docker build 1.18 Changes needed
--add-host value Y Y N
--authfile value Y N N
--build-arg argument=value Y Y N
--cache-from N Y Y
--cert-dir value Y N N
--cgroup-parent value Y Y N
--compress N Y #621 Closed
--cpu-period value Y Y N
--cpu-quota value Y Y N
--cpu-shares value Y Y N
--cpuset-cpus value Y Y N
--cpuset-mems value Y Y N
--creds [username[:password]] Y N N
--file pathname or URL, -f pathname or URL Y Y N
--force-rm N Y #622 Closed
--format format Y N #623 Closed
--iidfile N Y #624 Closed
--isolation N Y #625 Closed
--label N Y #626 Closed
--memory value, -m value Y Y N
--memory-swap value Y Y N
--network N Y #627 Closed
--no-cache N Y #628 Closed
--platform N Y #629 Closed (noop)
--pull Y Y N
--pull-always Y N N
--quiet, -q Y Y N
--rm N Y #598 Closed
--runtime path Y N N
--runtime-flag value Y N N
--security-opt value Y Y N
--shm-size /dev/shm Y Y N
--signature-policy pathname Y N N
--squash N Y #630 Closed
--stream N Y #631 Dropped
--tag tag, -t tag Y Y N
--target N Y #632 #1321
--tls-verify Y N N
--ulimit value Y Y N
--volume value, -v value Y Y N

Docker options from following URL
https://docs.docker.com/engine/reference/commandline/build/

May not be complete/perfect (--volume was missing)

@TomSweeneyRedHat
Copy link
Member Author

TomSweeneyRedHat commented Apr 24, 2018

@pixdrift thanks for putting this together. At a quick glance, most if not all of the ones that are "Yes" in Buildah, but "No" in Docker I'm fine with. A lot of those were additions to make logging into registries more secure and/or more convenient. For instance authfile, creds, tls-verify, etc. The ones that are "No" for Buildah and "Yes" for Docker are ones we'll have to look into further. I'm guessing @rhatdan will squash some, but the others we probably ought to open an issue for so folks can pick them off and we can track them. I'm going to guess that some of params in this category are new from when the set of params were established for Buildah.

I've added a "changes needed" column to you table and did a first pass scrub. @rhatdan?

FYI @mheon and @baude

@rhatdan
Copy link
Member

rhatdan commented Apr 24, 2018

I agree any one that is N for Buildah and Y for Docker, should have an issue opened for it. And people can just grab them and open a PR. Most should be fairly easy.

BTW This would be a decent table to add to the github repo to show compatibility.

@rhatdan
Copy link
Member

rhatdan commented Apr 24, 2018

Thanks @pixdrift great job.

@TomSweeneyRedHat
Copy link
Member Author

I've added an issue for each question mark in the table with the exception of #598 that @pixdrift created earlier. I've updated the table replacing the "?" with the issue number link.

@pixdrift
Copy link
Contributor

pixdrift commented Apr 24, 2018

Looks good @TomSweeneyRedHat

I picked up another minor discrepancy in that buildah bud --cpu-shares doesn't look to support the short parameter -c that docker does (not displayed in --help anyway, will double check).

Also, when issuing buildah bud --help, the output currently isn't alphabetically sorted (can make a ticket for this and check other --help output too).

@rhatdan
Copy link
Member

rhatdan commented May 25, 2018

@pixdrift Could you update your table.

@rhatdan
Copy link
Member

rhatdan commented Aug 2, 2018

@pixdrift Can we get this table updated? Perhaps as a docs file off of the readme.

@rhatdan
Copy link
Member

rhatdan commented Nov 27, 2018

@pixdrift Would love to see where we stand now.

@rhatdan
Copy link
Member

rhatdan commented Nov 27, 2018

@TomSweeneyRedHat and @umohnani8 I think we are close to having this done.

@rhatdan
Copy link
Member

rhatdan commented Mar 8, 2019

No work on this in months closing.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants