buildah bud --rm -t webserver . fails

[TomSweeneyRedHat]

Description

docker has this command: docker build --rm -t webserver . which if you replace docker with 'buildah' your receive the error:

Incorrect Usage: flag provided but not defined: -rm

If we're not going to support this, we should at least provide an error message which tells the user how to make it so.

Reported/Requested by @dustymabe

Output of buildah version:

Buildah v0.16

[rhatdan]

We should support it.

[pixdrift]

I was looking at rm when compiling the list for #599. The behaviour of --rm in docker is to remove intermediate containers after successful build (defaults to true). Is buildah bud currently generating/storing intermediate containers?

I suspect the expected behaviour of --rm is what buildah is already doing (not generating/storing intermediate containers after build).. and --rm=false is where the work would be matching docker behaviour.

[pixdrift]

@rhatdan, if this does match default buildah behaviour, would there be benefit in having a noop for the --rm for the time being, and then implementing --rm=false when the layer caching is implemented in #601?. This would improve compatibility in the short term while the caching capability is developed.

[rhatdan]

Sure Open a PR...

[pixdrift]

noop for --rm implemented in PR #639 from @rhatdan

[pixdrift]

@TomSweeneyRedHat, the original use case should work now without the -rm error.

[rhatdan]

I'm closing this since I believe we cover this in other issues.