Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildah bud --compress functionality is needed #621

Closed
TomSweeneyRedHat opened this issue Apr 24, 2018 · 5 comments
Closed

buildah bud --compress functionality is needed #621

TomSweeneyRedHat opened this issue Apr 24, 2018 · 5 comments

Comments

@TomSweeneyRedHat
Copy link
Member

Description
buildah bud --compress is missing and needs to be provided. This is functionality that Docker has.

#599 is the parent issue for this issue.

Output of buildah version:

Buildah v0.16

@rhatdan
Copy link
Member

rhatdan commented Apr 26, 2018

@mtrmac @umohnani8 Does containers/image support this now?

@mtrmac
Copy link
Contributor

mtrmac commented Apr 26, 2018

… and… what does it… do?

It seems to cause the CLI client to compress the “tarball of the current directory” which is sent to the daemon for processing the build; I can’t see how that even makes sense for Docker, assuming a local connection that is (maybe it does for a remote one), and for buildah which does not have a daemon, I guess it should just be ignored.

@umohnani8
Copy link
Member

@rhatdan do we need this flag since the build context is not being transmitted anywhere like in docker. I believe during planning yesterday we commented on the card asking if this flag should just be a NO-OP.
https://trello.com/c/IG96I45d/805-buildah-podman-build-compress-demo

@rhatdan
Copy link
Member

rhatdan commented Apr 26, 2018

SGTM. We will make this a NOOP just so scripts would work. I will open a PR.

@rhatdan
Copy link
Member

rhatdan commented May 25, 2018

Added --compress as a noop for compatibility.

@rhatdan rhatdan closed this as completed May 25, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants