Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced build push tests #215

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Enhanced build push tests #215

merged 2 commits into from
Oct 13, 2022

Conversation

cevich
Copy link
Member

@cevich cevich commented Oct 4, 2022

Depends on: #213

@cevich cevich added no_fedora_podman Don't build the fedora_podman image no_fedora-aws Don't build any fedora-aws images no_fedora-aws-arm64 Don't build any fedora-aws-arm64 images no_fedora-netavark Don't build the fedora-netavark image no_fedora-netavark-aws-arm64 Don't build the fedora-netavark-aws image no_fedora-podman-aws-arm64 Don't build the fedora-podman-aws image no_fedora-podman-py Don't build the fedora-podman-py image no_image-builder Don't build the image-builder image no_prior-fedora Don't build any prior-fedora images no_prior-fedora_podman Don't build the prior-fedora_podman image no_skopeo_cidev Don't build the skopeo_cidev image no_ubuntu labels Oct 4, 2022
@cevich cevich mentioned this pull request Oct 4, 2022
Merged
@cevich
Copy link
Member Author

cevich commented Oct 5, 2022

note to me: there's a failure on main that didn't happen in original PR.

@cevich cevich force-pushed the enhanced_build_push_tests branch 4 times, most recently from 6873f70 to 293afb8 Compare October 7, 2022 14:38
cevich added 2 commits October 13, 2022 10:44
@cevich
Only run container/image tests in PRs
5771b46 
None of these need to run in any other context.

Signed-off-by: Chris Evich <[email protected]>
@cevich
Resolve build-push test TODO
920fc13 
Modern versions of podman are able to execute foreign architecture
images properly.  Remove test workaround for podman 3.4.4.

Resolve testing TODOs that check for several important label fields set
on the manifest list.

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich force-pushed the enhanced_build_push_tests branch from 293afb8 to 920fc13 Compare October 13, 2022 14:44
@github-actions
Copy link

Cirrus CI build successful. Found built image names and IDs:

Stage Image Name IMAGE_SUFFIX
base fedora b6116914031230976
cache build-push c6116914031230976
cache fedora c6116914031230976

@cevich cevich marked this pull request as ready for review October 13, 2022 16:32
@cevich cevich merged commit 0385c4a into containers:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no_fedora_podman Don't build the fedora_podman image no_fedora-aws Don't build any fedora-aws images no_fedora-aws-arm64 Don't build any fedora-aws-arm64 images no_fedora-netavark Don't build the fedora-netavark image no_fedora-netavark-aws-arm64 Don't build the fedora-netavark-aws image no_fedora-podman-aws-arm64 Don't build the fedora-podman-aws image no_fedora-podman-py Don't build the fedora-podman-py image no_image-builder Don't build the image-builder image no_prior-fedora_podman Don't build the prior-fedora_podman image no_prior-fedora Don't build any prior-fedora images no_skopeo_cidev Don't build the skopeo_cidev image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cevich