Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FLAVOR build-arg support to build_push #213

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Add FLAVOR build-arg support to build_push #213

merged 1 commit into from
Oct 5, 2022

Conversation

cevich
Copy link
Member

@cevich cevich commented Sep 29, 2022

This is needed to support containers/buildah#4300

@cevich cevich added no_fedora_podman Don't build the fedora_podman image no_fedora-aws Don't build any fedora-aws images no_fedora-aws-arm64 Don't build any fedora-aws-arm64 images no_fedora-netavark Don't build the fedora-netavark image no_fedora-netavark-aws-arm64 Don't build the fedora-netavark-aws image no_fedora-podman-aws-arm64 Don't build the fedora-podman-aws image no_fedora-podman-py Don't build the fedora-podman-py image no_image-builder Don't build the image-builder image no_prior-fedora Don't build any prior-fedora images no_prior-fedora_podman Don't build the prior-fedora_podman image no_skopeo_cidev Don't build the skopeo_cidev image no_ubuntu labels Sep 29, 2022
@cevich cevich self-assigned this Sep 29, 2022
@cevich cevich force-pushed the build_arg_build_push branch from 8364fe9 to d614e6e Compare September 30, 2022 15:54
@cevich cevich mentioned this pull request Sep 30, 2022
Merged
@github-actions
Copy link

Cirrus CI build successful. Found built image names and IDs:

Stage Image Name IMAGE_SUFFIX
base fedora b4685105464606720
cache build-push c4685105464606720
cache fedora c4685105464606720

@cevich cevich force-pushed the build_arg_build_push branch from d614e6e to cb247a9 Compare September 30, 2022 16:55
@cevich cevich changed the title Add STAGE build-arg support to build_push Add FLAVOR build-arg support to build_push Sep 30, 2022
@cevich cevich force-pushed the build_arg_build_push branch 2 times, most recently from e87f6c8 to b1cd187 Compare October 3, 2022 18:13
@cevich cevich removed no_ubuntu no_skopeo_cidev Don't build the skopeo_cidev image no_prior-fedora Don't build any prior-fedora images no_fedora-aws Don't build any fedora-aws images no_fedora-aws-arm64 Don't build any fedora-aws-arm64 images no_fedora_podman Don't build the fedora_podman image no_prior-fedora_podman Don't build the prior-fedora_podman image no_fedora-netavark Don't build the fedora-netavark image labels Oct 3, 2022
@cevich cevich removed no_fedora-netavark-aws-arm64 Don't build the fedora-netavark-aws image no_fedora-podman-py Don't build the fedora-podman-py image no_image-builder Don't build the image-builder image no_fedora-podman-aws-arm64 Don't build the fedora-podman-aws image labels Oct 3, 2022
@cevich cevich force-pushed the build_arg_build_push branch 2 times, most recently from e6310d5 to 83690a0 Compare October 3, 2022 19:12
@cevich cevich mentioned this pull request Oct 3, 2022
Merged
@cevich cevich added no_prior-fedora Don't build any prior-fedora images no_prior-fedora_podman Don't build the prior-fedora_podman image labels Oct 3, 2022
@cevich cevich force-pushed the build_arg_build_push branch 2 times, most recently from a6feea6 to 549ebe3 Compare October 4, 2022 17:47
@cevich
Add FLAVOUR build-arg support to build_push
9d36bd0 
This is needed to support image-builds which rely on passing a build-arg
to indicate the flavour-name or type of image.  For example, `upstream`,
`testing`, or `stable`.  Accommodations are also made to continue
supporting the previous method - where the flavour is taken as the
base-name of the context directory.  To prevent any ambiguity, the
flavour argument will be preferred over the sub-directory name.

In all cases, the flavor value will be passed to buildah via
a `--build-arg FLAVOUR=<value>`.  Additionally it will
be passed to the `tag-version.sh` mod-script as the first argument,
with the command version number as the second argument.

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich mentioned this pull request Oct 4, 2022
Merged
@cevich cevich force-pushed the build_arg_build_push branch from 549ebe3 to 9d36bd0 Compare October 4, 2022 18:49
@cevich
Copy link
Member Author

cevich commented Oct 4, 2022 •
edited
Loading

Force-push: Splitting off addition of new tests into a separate PR #215

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Cirrus CI build successful. Found built image names and IDs:

Stage Image Name IMAGE_SUFFIX
base fedora b4678746211876864
base fedora-aws b4678746211876864
base fedora-aws-arm64 b4678746211876864
base image-builder b4678746211876864
base ubuntu b4678746211876864
cache build-push c4678746211876864
cache fedora c4678746211876864
cache fedora-aws c4678746211876864
cache fedora-netavark c4678746211876864
cache fedora-netavark-aws-arm64 c4678746211876864
cache fedora-podman-aws-arm64 c4678746211876864
cache fedora-podman-py c4678746211876864
cache ubuntu c4678746211876864

@cevich cevich marked this pull request as ready for review October 5, 2022 14:29
@cevich cevich merged commit 2bd0034 into containers:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cevich cevich

Labels
no_prior-fedora_podman Don't build the prior-fedora_podman image no_prior-fedora Don't build any prior-fedora images
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cevich