ilab-wrapper: Improve non-single subuid ranges error handling #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omertuc
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
rhatdan
reviewed
Aug 6, 2024
|
/lgtm |
eranco74
approved these changes
Aug 7, 2024
omertuc
force-pushed
the
bash
branch
3 times, most recently
from
fd4060c to
4118da9
Compare
|
Needs a rebase or to be closed, it the code was already merged. |
omertuc
force-pushed
the
bash
branch
2 times, most recently
from
926082d to
367b116
Compare
|
Force pushed to fix conflicts |
rhatdan
reviewed
Aug 7, 2024
# Background df88857 # Issue The current error handling for multiple subuid ranges is broken due to surprising behavior of `wc -l` which always returns `1` even when the input is empty. # Solution More carefully count the number of lines in the `CURRENT_USER_SUBUID_RANGE` variable # Additional changes 50fb00f had a small merge error, this commit fixes that. Signed-off-by: Omer Tuchfeld <[email protected]>
|
LGTM |
rhatdan
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
df88857
Issue
The current error handling for multiple subuid ranges is broken due to surprising behavior of
wc -lwhich always returns1even when the input is empty.Solution
More carefully count the number of lines in the
CURRENT_USER_SUBUID_RANGEvariableAdditional changes
omertuc@50fb00f had a small merge error, this commit fixes that.