ilab-wrapper: don't map UIDs if we're already running as root #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omertuc
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
|
cc @eranco74 |
# Background See df88857 # Issue Introduced a regression [1] where it's no longer possible to run the script as root, as the subuid map ends up being empty and this causes an error: ``` Error: invalid empty host id at UID map: [1 1] ``` # Solution Avoid UID mapping if we're already running as root. # Motivation We want to also be able to run the script as root, for example as part of a systemd service. [1] RHELAI-798 Signed-off-by: Omer Tuchfeld <[email protected]>
|
Force push reason: DCO |
|
LGTM |
|
Forgot to update duplicated wrapper, followup (& additional fixes) here: #730 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
See df88857
Issue
Introduced a regression [1] where it's no longer possible to run the script as root, as the subuid map ends up being empty and this causes an error:
Solution
Avoid UID mapping if we're already running as root.
Motivation
We want to also be able to run the script as root, for example as part of a systemd service.
[1] RHELAI-798