Fix React Native subpath imports #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
reviewed
Nov 5, 2024
| unstable_allowRequireContext: true, | ||
| }, | ||
| resolver: { | ||
| unstable_enablePackageExports: true, |
There was a problem hiding this comment.
It's added to the FAQ here: connectrpc/connectrpc.com#218
If that's too difficult to link to, can we add a comment that replicates the gist of it? E.g.
Connect-ES and Protobuf-ES use package exports. We need to enable support for them in Metro. See https://metrobundler.dev/docs/package-exports/
There was a problem hiding this comment.
Lmk if this is what you had in mind.
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
smaye81
force-pushed
the
sayers/fix_rn_subpath_imports
branch
from
81934b0 to
0f1dd47
Compare
timostamm
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Metro bundler with React Native requires enabling package exports (docs) via a Metro config file. This adds said file and some necessary dependencies.
Note that we also spell this out in our Protobuf-ES docs.
It seems odd to have to use the
react-native-svg-transformerhere. But without it, we get asset errors. This combination here appears to be the right incantation to get things to work. Taken from this issue.