-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
es/v2: Port docs #218
es/v2: Port docs #218
Conversation
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
"Setting fetch() options" no longer fits. Moving it to the next section about transports, to be updated. Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
2f222b6
to
1ca725b
Compare
Signed-off-by: Timo Stamm <[email protected]>
1ca725b
to
cae9b0e
Compare
@@ -110,21 +102,3 @@ Usage: | |||
```ts | |||
await useClient(ElizaService).say({sentence: "I feel happy."}); | |||
``` | |||
|
|||
## Roll your own client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's worthwhile to link to our custom-client
example here? https://github.com/connectrpc/examples-es/tree/main/custom-client? I know it's been a question in public Slack a couple times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must have missed the cases in public slack, or I forgot. Maybe it's better to keep this section then.
The custom client example hasn't been updated yet. Taking a note to restore this section once it's updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restoring in #224.
Signed-off-by: Timo Stamm <[email protected]>
As a follow-up to #217, #215, #219, this updates the remainder of the Node.js and Web docs for the upcoming version 2.
Mechanical changes:
createPromiseClient
tocreateClient
protoc-gen-connect-es
plugin (protoc-gen-es
also generates service schemas now) including generated SDKsimport_extension
changed tonone
, so we don't generate them anymore)new
for Protobuf messages with object literals or calls tocreate()
Breaking changes in Connect-ES:
@connectrpc/connect-web
transports and explain how to do the same withfetch
Improved compatibility:
Drive-by changes: