feat: Implement schemaProvider for UDTFs #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purplefox
force-pushed
the
schema_provider_5
branch
2 times, most recently
from
ef8270b to
eaa51bf
Compare
2 tasks
purplefox
force-pushed
the
schema_provider_5
branch
2 times, most recently
from
11231b2 to
d0543c3
Compare
purplefox
force-pushed
the
schema_provider_5
branch
from
d0543c3 to
711e12e
Compare
purplefox
force-pushed
the
schema_provider_5
branch
from
711e12e to
fd0c6b0
Compare
agavra
reviewed
Oct 31, 2019
ksql-common/src/main/java/io/confluent/ksql/function/KsqlFunctionBase.java
Show resolved
Hide resolved
ksql-common/src/main/java/io/confluent/ksql/function/KsqlTableFunction.java
Show resolved
Hide resolved
agavra
approved these changes
Oct 31, 2019
ksql-engine/src/main/java/io/confluent/ksql/function/udtf/array/Explode.java
Outdated
Show resolved
Hide resolved
ksql-engine/src/main/java/io/confluent/ksql/planner/plan/FlatMapNode.java
Outdated
Show resolved
Hide resolved
JimGalasyn
approved these changes
Oct 31, 2019
2 tasks
purplefox
added a commit
to purplefox/ksql
that referenced
this pull request
Nov 1, 2019
This commit allows schemaProvider to be used when specifying return values for UDTFs in the same way as UDFs.
2 tasks
purplefox
added a commit
to purplefox/ksql
that referenced
this pull request
Nov 1, 2019
This commit allows schemaProvider to be used when specifying return values for UDTFs in the same way as UDFs.
2 tasks
purplefox
added a commit
to purplefox/ksql
that referenced
this pull request
Nov 2, 2019
This commit allows schemaProvider to be used when specifying return values for UDTFs in the same way as UDFs.
purplefox
added a commit
to purplefox/ksql
that referenced
this pull request
Nov 2, 2019
This commit allows schemaProvider to be used when specifying return values for UDTFs in the same way as UDFs.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #3688
This PR is in a stack. The previous PR is #3689. please don't review the commits from the previous PR you will see in here.
This PR implements @schemaProvider for UDTFs. To avoid code duplication with KsqlFunction which does the same, KsqlFunction and KsqlTableFunction both inherit from KsqlBaseFunction which contains the shared implementation.
Testing done
Added some more tests for invalid UDTFs
Added some tests for UDTFs with SchemaProvider annotation
Improved QTT tests
Reviewer checklist