Refactor: Split UdfLoader into multiple files #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purplefox
force-pushed
the
split_udf_loader_4
branch
from
ad9147c to
70c93a2
Compare
2 tasks
purplefox
force-pushed
the
split_udf_loader_4
branch
3 times, most recently
from
5234f22 to
35824c4
Compare
2 tasks
purplefox
force-pushed
the
split_udf_loader_4
branch
from
35824c4 to
a35d739
Compare
agavra
approved these changes
Oct 30, 2019
There was a problem hiding this comment.
I skimmed this PR to make sure the code structure made sense to me, I didn't look at the guts of the classes sine I trust that it was all moved code (as you mentioned). Thanks @purplefox!
purplefox
added a commit
that referenced
this pull request
Oct 30, 2019
This commit refactors UdfLoader to be more manageable - it was becoming a sprawling mega-class that did too much and suffered from poor cyclomatic complexity. There is more or less zero new code in this PR - it pretty much extracts existing code to new classes and does some renaming. Now: UdfLoader loads udfs UdafLoader loads udafs UdtfLoader loads udtfs UserFunctionLoader is the corordinator for the overall loading process FunctionLoaderUtils contains static util functions used by the different loaders UdfLoader Passes checkstyle cyclomatic complexity check (previously it didn't)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the 4th PR in a stack. The previous PR is #3687. please don't review the commits from the previous PR you will see in here.
This PR refactors UdfLoader to be more manageable - it was becoming a sprawling mega-class that did too much and suffered from poor cyclomatic complexity.
There is more or less zero new code in this PR - it pretty much extracts existing code to new classes and does some renaming.
Now:
Testing done
Non functional change.
Reviewer checklist