Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Remove 'pip install' options in recipes #584

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthewfeickert
Copy link

Resolves #582

Description

  • Remove --no-deps --no-build-isolation pip install options in recipes as the build tool (e.g. conda-build, rattler-build) will enforce all required pip install options itself at build time.

c.f.:

* Remove --no-deps --no-build-isolation 'pip install' options in recipes as
  the build tool (e.g. conda-build, rattler-build) will enforce all required
  'pip install' options itself at build time.
@matthewfeickert matthewfeickert force-pushed the mnt/remove-pip-install-options branch from cd231f2 to d222e89 Compare November 18, 2024 07:29
@matthewfeickert matthewfeickert marked this pull request as ready for review November 18, 2024 07:29
@matthewfeickert matthewfeickert requested a review from a team as a code owner November 18, 2024 07:30
@matthewfeickert
Copy link
Author

This is ready for review.

@ocefpaf
Copy link
Contributor

ocefpaf commented Nov 18, 2024

@wolfv we can't do this while we use conda-build b/c of the multiple outputs bug. However, if/when we drop conda-build, do you know if rattler-build will behave as expected with multiple outputs?

@matthewfeickert
Copy link
Author

we can't do this while we use conda-build b/c of the multiple outputs bug.

Out of curiosity, is there an issue for this?

@ocefpaf
Copy link
Contributor

ocefpaf commented Nov 18, 2024

Out of curiosity, is there an issue for this?

I'm pretty sure there is one, or more, in conda-build. To be fair, are trying to keep conda-build on life support as we move to rattler-build, so I don't think anyone is working on that.

@marcelotrevisani
Copy link
Member

@wolfv we can't do this while we use conda-build b/c of the multiple outputs bug. However, if/when we drop conda-build, do you know if rattler-build will behave as expected with multiple outputs?

after we drop conda-build and start to use rattle, we could add this when the --strict-conda-forge flag is enabled

@matthewfeickert
Copy link
Author

matthewfeickert commented Nov 20, 2024

As I don't know the full history of things, or even the technical problems with conda-build, should I instead change this PR to add in --ignore-installed as that's also a flag set (conda/conda-build#5543) and then once conda-forge has gone full rattler-build removing all the flags can be revisited?

I also don't know if there is a projected timeline for full rattler-build adoption. (2025? 2026?)

@marcelotrevisani
Copy link
Member

As I don't know the full history of things, or even the technical problems with conda-build, should I instead change this PR to add in --ignore-installed as that's also a flag set (conda/conda-build#5543) and then once conda-forge has gone full rattler-build removing all the flags can be revisited?

I also don't know if there is a projected timeline for full rattler-build adoption. (2025? 2026?)

yeah, I think that would be nice to add the flag for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: why is --no-deps --no-build-isolation set?
3 participants