-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Remove 'pip install' options in recipes #584
base: main
Are you sure you want to change the base?
MNT: Remove 'pip install' options in recipes #584
Conversation
* Remove --no-deps --no-build-isolation 'pip install' options in recipes as the build tool (e.g. conda-build, rattler-build) will enforce all required 'pip install' options itself at build time.
cd231f2
to
d222e89
Compare
This is ready for review. |
@wolfv we can't do this while we use conda-build b/c of the multiple outputs bug. However, if/when we drop conda-build, do you know if rattler-build will behave as expected with multiple outputs? |
Out of curiosity, is there an issue for this? |
I'm pretty sure there is one, or more, in conda-build. To be fair, are trying to keep conda-build on life support as we move to rattler-build, so I don't think anyone is working on that. |
after we drop conda-build and start to use rattle, we could add this when the |
As I don't know the full history of things, or even the technical problems with I also don't know if there is a projected timeline for full |
yeah, I think that would be nice to add the flag for now :) |
Resolves #582
Description
--no-deps --no-build-isolation
pip install
options in recipes as the build tool (e.g.conda-build
,rattler-build
) will enforce all requiredpip install
options itself at build time.c.f.: