Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add atlas-schema into conda-forge #28268

Merged
merged 5 commits into from
Nov 20, 2024
Merged

feat: add atlas-schema into conda-forge #28268

merged 5 commits into from
Nov 20, 2024

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Nov 19, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/atlas-schema/meta.yaml) and found some lint.

Here's what I've got...

For recipes/atlas-schema/meta.yaml:

  • ❌ The home item is expected in the about section.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/atlas-schema/meta.yaml) and found it was in an excellent condition.

@kratsg
Copy link
Contributor Author

kratsg commented Nov 19, 2024

@conda-forge/help-python, ready for review!

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 19, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/atlas-schema/meta.yaml) and found some lint.

Here's what I've got...

For recipes/atlas-schema/meta.yaml:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

recipes/atlas-schema/meta.yaml Outdated Show resolved Hide resolved
recipes/atlas-schema/meta.yaml Outdated Show resolved Hide resolved
@matthewfeickert
Copy link
Member

@kratsg you can keep it noarch.

@kratsg
Copy link
Contributor Author

kratsg commented Nov 19, 2024

@kratsg you can keep it noarch.

done

@matthewfeickert
Copy link
Member

matthewfeickert commented Nov 19, 2024

@kratsg, btw, for future testing the conda-forge team made it even easier now to do local builds before opening up an "Add project" PR by adding a pixi project config. So you now can just do

staged-recipes/README.md

Lines 49 to 51 in 566507c

* `pixi run build-linux`: will launch a Docker container, provision all the necessary tools and build your recipe for Linux.
* `pixi run build-osx`: will provision a conda environment with the necessary tools to build your recipe for macOS. This involves fetching and caching the necessary Apple SDKs.
* `pixi run build-win`: will provision a conda environment with the necessary tools to build your recipe for Windows.

for the next project you add to test everything before pushing. 🚀

recipes/atlas-schema/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/atlas-schema/meta.yaml) and found it was in an excellent condition.

@kratsg
Copy link
Contributor Author

kratsg commented Nov 20, 2024

@ocefpaf - all changes commited/made.

@matthewfeickert matthewfeickert mentioned this pull request Nov 20, 2024
10 tasks
@matthewfeickert
Copy link
Member

Thanks very much for all your help and patience, @ocefpaf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants