Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pysciencemode #28220

Merged
merged 26 commits into from
Nov 24, 2024
Merged

Adding pysciencemode #28220

merged 26 commits into from
Nov 24, 2024

Conversation

Kev1CO
Copy link
Contributor

@Kev1CO Kev1CO commented Nov 14, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyScienceMode/meta.yaml) and found some lint.

Here's what I've got...

For recipes/pyScienceMode/meta.yaml:

  • ❌ There are too few lines. There should be one empty line at the end of the file.

For recipes/pyScienceMode/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 14, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyScienceMode/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pyScienceMode/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

@Kev1CO Kev1CO changed the title Adding pyScienceMode recipe Adding pysciencemode Nov 15, 2024
@Kev1CO
Copy link
Contributor Author

Kev1CO commented Nov 15, 2024

@conda-forge/help-python

@Kev1CO
Copy link
Contributor Author

Kev1CO commented Nov 15, 2024

Alike other pull requests, I have an issue with Build osx osx_64.
If you have any information on how to fix it, it would be appreciated.
Have a good day !

recipes/pyScienceMode/meta.yaml Outdated Show resolved Hide resolved
@Kev1CO
Copy link
Contributor Author

Kev1CO commented Nov 15, 2024

@matthewfeickert Thanks for the advices !
The osx_64 problem seems to hit several PR.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyScienceMode/meta.yaml) and found it was in an excellent condition.

@xhochy xhochy merged commit 0ea13ec into conda-forge:main Nov 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants