Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: only set level if needed #5384

Merged
merged 5 commits into from
Jun 25, 2024
Merged

perf: only set level if needed #5384

merged 5 commits into from
Jun 25, 2024

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented Jun 21, 2024 •
edited
Loading

Description

This PR tries to address #5382 by only calling setLevel if needed. I am trying it instead of #5383 since it is less intrusive and I am seeing odd test failures in that PR.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

closes #5383
closes #5382

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 21, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 21, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5384 will not alter performance

Comparing beckermr:test-effective-level (38cfad1) with main (3a09f13)

Summary

✅ 3 untouched benchmarks

@beckermr
Copy link
Contributor Author

@minrk Can you test this approach?

minrk
minrk reviewed Jun 21, 2024
View reviewed changes
conda_build/utils.py Outdated Show resolved Hide resolved
@minrk
Copy link
Contributor

minrk commented Jun 21, 2024

Yeah, this gets ~90% of the savings in #5383. Thanks!

beckermr
beckermr commented Jun 21, 2024
View reviewed changes
conda_build/utils.py Outdated Show resolved Hide resolved
@beckermr beckermr marked this pull request as ready for review June 21, 2024 21:12
@beckermr beckermr requested a review from a team as a code owner June 21, 2024 21:12
@beckermr beckermr mentioned this pull request Jun 21, 2024
Closed
3 tasks
jaimergp
jaimergp previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a tiny typo in the news file.

conda_build/utils.py Show resolved Hide resolved
news/5384-test-log-level Outdated Show resolved Hide resolved
@beckermr beckermr enabled auto-merge (squash) June 25, 2024 14:11
@beckermr
Copy link
Contributor Author

Woops this needs another approval @jaimergp!

@beckermr beckermr requested a review from jaimergp June 25, 2024 14:13
@beckermr beckermr merged commit c7a1e9b into conda:main Jun 25, 2024
28 checks passed
@beckermr beckermr deleted the test-effective-level branch June 25, 2024 20:10
This was referenced Jun 28, 2024
Merged
Open
@beeankha beeankha mentioned this pull request Jul 16, 2024
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minrk minrk minrk left review comments

@kenodegard kenodegard kenodegard approved these changes

@jaimergp jaimergp Awaiting requested review from jaimergp

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

utils.get_logger dominates rerender performance
5 participants
@beckermr @minrk @jaimergp @kenodegard @conda-bot