Include file path when generating file hash #4821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @timkpaine. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature. |
10 tasks
conda-bot
added
the
cla-signed
|
@conda/builds-tools Any suggestion where @timkpaine could add a test for this? |
jezdez
changed the title
CodSpeed Performance ReportMerging #4821 will not alter performanceComparing Summary
|
|
pre-commit.ci autofix |
isuruf
reviewed
Apr 2, 2024
jaimergp
reviewed
Apr 12, 2024
jaimergp
reviewed
Apr 12, 2024
jaimergp
reviewed
Apr 12, 2024
|
Ready for review @conda/builds-tools |
jaimergp
reviewed
Jun 3, 2024
isuruf
changed the title
jaimergp
reviewed
Jun 3, 2024
jaimergp
previously approved these changes
Jun 3, 2024
Co-authored-by: jaimergp <[email protected]>
jaimergp
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include file contents when generating file hash, in case different files have the same contents.
Fixes: #4814
Xref: conda-forge/staged-recipes#22323
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?I'm not sure how / where to test this, please advise.