Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #166: Error on miniconda-version *not* specified instead of when it *is* specified. #189

Merged
merged 10 commits into from
Nov 29, 2021
Merged

Fixes #166: Error on miniconda-version *not* specified instead of when it *is* specified. #189

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3104b4e
Fixes #166
chrisjbillington Aug 9, 2021
8cc7c0e
Rebuild /dist
chrisjbillington Aug 9, 2021
71ac342
bring in example from PR#168
jaimergp Aug 10, 2021
83c1796
add some more rules for x86 and windows
jaimergp Aug 10, 2021
d311675
add semver
jaimergp Aug 10, 2021
e7ca0a1
check for empty versions
jaimergp Aug 10, 2021
6245009
we expect and error on ubuntu
jaimergp Aug 10, 2021
0aa22fa
make sure we have it right on windows too
jaimergp Aug 10, 2021
3cc7601
indent
jaimergp Aug 10, 2021
416f1d0
update readme
jaimergp Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/setup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13607,7 +13607,7 @@ const RULES = [
(i) => !!(i.installerUrl &&
!constants.KNOWN_EXTENSIONS.includes(urlExt(i.installerUrl))) &&
`'installer-url' extension '${urlExt(i.installerUrl)}' must be one of: ${constants.KNOWN_EXTENSIONS}`,
(i) => !!(i.minicondaVersion && i.architecture !== "x64") &&
(i) => !!(!i.minicondaVersion && i.architecture !== "x64") &&
`'architecture: ${i.architecture}' requires "miniconda-version"`,
];
/*
Expand Down
2 changes: 1 addition & 1 deletion src/input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const RULES: IRule[] = [
constants.KNOWN_EXTENSIONS
}`,
(i) =>
!!(i.minicondaVersion && i.architecture !== "x64") &&
!!(!i.minicondaVersion && i.architecture !== "x64") &&
`'architecture: ${i.architecture}' requires "miniconda-version"`,
];

Expand Down