Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #166: Error on miniconda-version *not* specified instead of when it *is* specified. #189

Merged
merged 10 commits into from
Nov 29, 2021

Conversation

chrisjbillington
Copy link
Contributor

A simple fix to what appeared to be a simple bug.

Raise an error if on non-x64 architectures, miniconda-version is not specified, instead of when it is specified.

Raise an error if on non-x64 architectures, `miniconda-version` is *not*
specified, instead of when it *is* specified.
@jaimergp
Copy link
Member

jaimergp commented Aug 9, 2021

Thanks! Do we need a test for this or is it enough with what we have so far?

@chrisjbillington
Copy link
Contributor Author

I thought I'd add that this does not fix the more general problem of old conda builds (many of which are 32-bit) being unsupported - ongoing attempts to address that issue are in #168.

However, some 32-bit builds, namely Windows, have recent relases:

Miniconda3-latest-Windows-x86.exe 55.3M 2021-07-21 11:05:08 a082be7ef6dd4f14b974dab2d78c5693

So this fix restores the ability to use them, at least.

@ktbarrett
Copy link
Contributor

ktbarrett commented Aug 9, 2021

@jaimergp I think tests would show that 32 bit support is still not quite there, but I don't think that fact should block this obvious bugfix from coming in.

Copy link
Member

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd have @bollwyvl have a look too!

@bollwyvl
Copy link
Contributor

Yep, the fix looks good. As it was a bug, we probably do need a test, which can then also be used for documentation purposes in the README.

Also it probably needs to have the build re-run to update the transpiled assets

@jaimergp
Copy link
Member

This seems to be successfully using x86-latest on Windows now and failing (on purpose) on Ubuntu/Mac. I did this because latest x86-Ubuntu predates 4.6, which is the oldest we are supporting currently.

@chrisjbillington
Copy link
Contributor Author

Thanks very much for fleshing this out @jaimergp! That one-character change was getting close to the limits of what I might be able to do with javascript. Really appreciate it!

@ktbarrett
Copy link
Contributor

Any status on this?

@jaimergp
Copy link
Member

Let's ping core :) @conda-incubator/setup-miniconda

@ktbarrett
Copy link
Contributor

3 months later this has been approved, but still hasn't been merged. What gives?

@goanpeca
Copy link
Member

Whoops, this fell under the cracks! Sorry

Merging˜!

@chrisjbillington chrisjbillington deleted the fix-166 branch December 12, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants