Create patched YML in place #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bollwyvl
commented
Mar 31, 2021
| @@ -1,6 +1,25 @@ | |||
| name: "Setup Miniconda" | |||
| author: Gonzalo Peña-Castellanos (@goanpeca) | |||
| description: "Set up Conda package and environment manager with Miniconda." | |||
|
|
|||
| runs: | |||
There was a problem hiding this comment.
just moved these up top so they were more discoverable
bollwyvl
commented
Mar 31, 2021
src/outputs.ts
Outdated
| core.setOutput(constants.OUTPUT_ENV_FILE_PATH, path.resolve(envFile)); | ||
| core.setOutput(constants.OUTPUT_ENV_FILE_CONTENT, envContent); | ||
| core.setOutput(constants.OUTPUT_ENV_FILE_PATCHED, patched ? "true" : "false"); | ||
| core.saveState(constants.OUTPUT_ENV_FILE_PATCHED, patched); |
There was a problem hiding this comment.
gah, i didn't know about saveState... should be using that instead of dynamicOptions or whatever... though it's all anys all the way down.
bollwyvl
commented
Mar 31, 2021
src/setup.ts
Outdated
| inputs.cleanPatchedEnvironmentFile === "true" && | ||
| core.getState(constants.OUTPUT_ENV_FILE_PATCHED) | ||
| ) { | ||
| await core.group("Cleaning up patched environment-file...", async () => |
There was a problem hiding this comment.
some future refactor could make this into a "post" step...
There was a problem hiding this comment.
Mind creating an issue to keep this on the top of our heads @bollwyvl ?
bollwyvl
changed the title
|
Tests are up... I don't know how I lose my bash knowledge on a seeming day-to-day basis... |
|
gah, didn't add a test for |
|
Ok, does the |
|
Will cut a new release! |
|
Released 2.1.1 @bollwyvl ! |
|
Thanks all!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Changes
setup-miniconda-patched-{environment.yml}in-place (to restore compatibility withpip: ["-r requirements.txt"](Environment file with pip dependency file #162) or other cases, e.g.-e .(would also break today)environment-file(-content|-was-patched)outputs about the effectiveenvironment-fileusedclean-patched-environment-file(defaulttrue) because I don't like actions leaving junk i don't ask for