-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy channels before reversing #161
Copy channels before reversing #161
Conversation
By inspection, this is fixing the issue: the order is as set in the original yaml. I don't know how to simply retrieve the logs from within the action (if that's even possible), but otherwise this is ready for review. |
I guess we could hoist the "effective used environment" to an action output... |
So what was the issue? |
right, gory details on #160 |
Huh, that's surprising indeed, at least coming from the Python world. If that's the case and this fixes the misbehavior, this LGTM. How would you like to check for the right behavior? Diffing |
Yeah dunno, re: testing.... Maybe something in conda-meta/history?
|
Looks good @bollwyvl Should I make a 2.1.1 release? |
Good by me to release unless we can figure out what the other fresh issue
is regarding python-version... #158... Might be a change, but not
necessarily a _bug_ whereas this definitely was.
|
.slice
to copy channels before reversingpackage-lock.json
after installing from fresh environmentenvironment-patched.yml
? Hoist to output?