-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tensorflow v2.18.0 #408
base: main
Are you sure you want to change the base?
tensorflow v2.18.0 #408
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.11.09.23.22.20
…nda-forge-pinning 2024.11.10.22.41.52
yes, but somebody has to the hard work of getting the patches updated. |
d488a43
to
db1e370
Compare
I cancel the running CI. As pointed at #405 (comment), the CI hangs at tensorflow/tensorflow@9b5fa66#diff-4d5f3192809ec1b9add6b33007e0c50031ad9a0a2f3f55a481b506468824db2c |
Thanks for the comment! I was a bit away (longer than expected) and did not remember on what my local changes were. They are related to the new hermetic CUDA. Someone should port the stuff I did in jaxlib over here. |
…onda-forge-pinning 2024.12.12.09.21.41
@traversaro @njzjz It would be nice if you could have a look here, too. I have no deep CUDA knowledge and applying the |
Sure. The error is:
right? At a first glance there is some library that directly links |
Yes. |
I reproduce the error locally. There is only |
jaxlib may need the same fix.
Any idea why
|
I found that this error disappears on a GPU machine (setting |
…onda-forge-pinning 2024.12.16.21.51.05
This file is in |
|
Right adding the args The alternative if we don't actually want to test the package and merely want to test its existence, would be to use |
(1) doesn't sound so bad, but I do want to know (cause I'm not familiar with this part of the stack) if linking to the driver's |
would we retain the ability to use |
The default build approach is to include a At runtime, However what seems to be happening in this build is Why does Some hypotheses worth testing...
What solution we pick should depend on what the TensorFlow build system is trying to accomplish |
Side note: It is possible to Here is a simple example of this behavior from Linux ARM conda create -n tst_cuda_stub python=3.12 ipython cuda-nvcc
conda activate tst_cuda_stub In [1]: import ctypes
In [2]: ctypes.cdll.LoadLibrary(
...: "/opt/conda/envs/tst/targets/sbsa-linux/lib/stubs/libcuda.so"
...: )
Out[2]: <CDLL '/opt/conda/envs/tst/targets/sbsa-linux/lib/stubs/libcuda.so', handle aaaacafa37c0 at 0xffff85e2e720> Am just not clear on why the TensorFlow wants to load |
We have an explicit requirement on tensorflow-feedstock/recipe/meta.yaml Lines 261 to 262 in dd13456
So we already don't support that (well, unless someone uses CONDA_CUDA_OVERRIDE ). I'm not saying that losing this ability would be desirable, just trying to figure out why it's a concern in the first place.
|
I think this is a fair question. The reason that
I am personally in camp 2, though, years ago, I was in camp 1. If I recall correctly, one of the (many) reasons we added |
I mean, how well can you test your setup if you're on a system that will end up taking completely different code paths (CPU vs. GPU) compared to the target environment? In any case, I'm in favour of keeping the ability to run without a GPU driver, but at the same time, I don't think it's worth an extreme maintenance investement if indeed upstream tensorflow now requires that. |
According to their docs, no GPU should be needed at build time 🤔
|
Ok we could add the stub library to the library search path at build time |
Although bazel is able to download cuda including drivers, in conda-forge, we set the environment variable Related documentation can be found here: https://github.com/openxla/xla/blob/main/docs/hermetic_cuda.md "When CUDA forward compatibility mode is disabled, Bazel targets will use User Mode and Kernel Mode Drivers pre-installed on the system." |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11511568857 - please use this URL for debugging.