Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorflow 2.18.0-rc1 #405

Closed
wants to merge 2 commits into from
Closed

tensorflow 2.18.0-rc1 #405

wants to merge 2 commits into from

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Oct 18, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@xhochy
Copy link
Member Author

xhochy commented Oct 18, 2024

Theoretically this supports NumPy 2 and Python 3.13 but we first need to migrate h5py.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@xhochy
Copy link
Member Author

xhochy commented Oct 18, 2024

Python 3.13 depends on conda-forge/h5py-feedstock#148

@hmaarrfk
Copy link
Contributor

Does building complete?

I'm wondering if we can at least add a test to stay aware of things like:
#296 (comment)

@xhochy
Copy link
Member Author

xhochy commented Oct 18, 2024

Does building complete?

For the non-CUDA variants, it works. I have cancelled the jobs as I realised that the CUDA jobs just hang at the ./configure step and would only be a waste of resource. I now what has to be fixed with CUDA to compile (same fixes as in jaxlib) but I'll probably do them next week.

Is there anything in #296 (comment) which we could test on a non-CUDA system?

@hmaarrfk
Copy link
Contributor

same fixes as in jaxlib

I really tried hard to read your comments on the jax repo to see if it was something I could fix myself.

Is there anything in #296 (comment) which we could test on a non-CUDA system?

I was hoping we could "force" some compilation (but not execution). That said I don't know enough about the workings of tensorflow for this.

@h-vetinari
Copy link
Member

Python 3.13 depends on conda-forge/h5py-feedstock#148

AFAIR 2.18 is also the first version to support numpy 2.0

@xhochy
Copy link
Member Author

xhochy commented Oct 20, 2024

I have both added locally and will push them with some fixes in the next days. If anyone is eager to be faster, happy to see it but let me know 🙃

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Nov 3, 2024

would you be willing to push your fixes? curious if we can get the protobuf going with 2.18.0 now that it is release.

@h-vetinari h-vetinari mentioned this pull request Nov 13, 2024
3 tasks
@xhochy xhochy closed this Nov 28, 2024
@xhochy xhochy deleted the 2.18.0 branch November 28, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants