Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meta.yaml to refer to libparallelproj #80

Merged
merged 5 commits into from
Apr 23, 2023

Conversation

gschramm
Copy link
Contributor

update parallelproj req. to libparallelproj (paralleproj >=1.3.4 now also contains python wrappers that are not needed for STIR)

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

update parallelproj req. to libparallelproj (paralleproj >=1.3.4 now also contains python wrappers that are not needed for STIR)
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@gschramm
Copy link
Contributor Author

@conda-forge-admin, please rerender

@gschramm
Copy link
Contributor Author

@KrisThielemans The conda-forge recipe for parallelproj >= 1.3.4 now creates two outputs:

  1. the libparallelproj package (previously called parallelproj package) shipping the openmp/cuda libs
  2. the parallelproj package containing python wrappers for the libs above.

Since STIR does not use the python-interface to the parallelproj libs, I think it is cleaner to list libparallelproj as requirement.

@gschramm
Copy link
Contributor Author

@h-vetinari I am trouble using libparallelproj as req. in this feestock. I am gettin the error:

The reported errors are:
- Encountered problems while solving:
-   - nothing provides requested libparallelproj * h*

Is this because the run_export in the parallelproj recipe should be
- libparallelproj =*=cpuh* instead of - libparallelproj =*=h* ?

Co-authored-by: h-vetinari <[email protected]>
@gschramm
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/stir-feedstock/actions/runs/4776220820.

remove cpu/cuda selectors for libparallelproj as test
@KrisThielemans
Copy link
Contributor

some weird errors in run_SPECT_tests.sh https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=694883&view=logs&j=d1321064-f6c3-56b7-0172-6d994d01c836&t=39022612-2533-571e-7b41-94814e7d38bb&l=8670

Running FBP2D FBP2D.par
the axis to invert is x
WARNING: input images do not have the same characteristics.
Not the same index ranges.
There were problems here!

This seems to happen with Linux builds with gcc 11.3 or more recent, and doesn't have anything to do with parallelproj. Even more weirdly, that equivalent job (with gcc 11.3) run on 18 April worked fine, see https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=692172&view=logs&j=d1321064-f6c3-56b7-0172-6d994d01c836&t=39022612-2533-571e-7b41-94814e7d38bb&l=8862

Maybe a numerical precision error in checking voxel sizes or so.

I guess I'll try and merge

@KrisThielemans KrisThielemans changed the title Update meta.yaml Update meta.yaml to refer to libparallelproj Apr 23, 2023
@KrisThielemans
Copy link
Contributor

@gschramm ok?

@gschramm
Copy link
Contributor Author

@KrisThielemans just saw, that they way we constructed the build strings is also sub-optimal (see @h-vetinari comment above for the build strings in parallelproj). So before merging right now, I will adjust the build strings such that they don't contain a period and reflect the python version used during the build.

update build strings
@gschramm
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/stir-feedstock/actions/runs/4778784451.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants