Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_SPECT_tests.sh failures for FBP2D on conda-forge #1193

Closed
KrisThielemans opened this issue Apr 27, 2023 · 3 comments · Fixed by #1234
Closed

run_SPECT_tests.sh failures for FBP2D on conda-forge #1193

KrisThielemans opened this issue Apr 27, 2023 · 3 comments · Fixed by #1234

Comments

@KrisThielemans
Copy link
Collaborator

See conda-forge/stir-feedstock#80 (comment)
@KrisThielemans
Copy link
Collaborator Author

fails here

STIR/src/include/stir/DiscretisedDensity.inl

Lines 97 to 100 in 63c2e9c

if (other.get_index_range() != this->get_index_range())
{
explanation = "Not the same index ranges.";
return false;

so not a rounding error

@KrisThielemans KrisThielemans mentioned this issue Jun 2, 2023
Closed
This was referenced Jul 16, 2023
Closed
Merged
@KrisThielemans
Copy link
Collaborator Author

Likely caused by

STIR/src/buildblock/VoxelsOnCartesianGrid.cxx

Line 303 in 4a93912

x_size_used = 2*static_cast<int>(ceil(FOVradius_in_mm / get_voxel_size().x())) + 1;

Checking in a debugger, the ratio "as float" is equal to 129. It is conceivable this is 129.0001 on some systems, leading to 130 voxels on some systems, and 129 on others (our comparison file uses 129).

Of course, 129 is a weird number for a detector with 128 elements, but that's another issue.

KrisThielemans added a commit to KrisThielemans/STIR-1 that referenced this issue Aug 20, 2023
@KrisThielemans
fix xy imagesize of FBP SPECTUB image in test
d70d8b8 
The code determining the xy image size is sensitive to rounding errors,
so we now say in the .par file what we expect.

Fixes UCL#1193
KrisThielemans added a commit to KrisThielemans/STIR-1 that referenced this issue Aug 20, 2023
@KrisThielemans
fix xy imagesize of FBP SPECTUB image in test
b031550 
The code determining the xy image size is sensitive to rounding errors,
so we now say in the .par file what the test expects.

Fixes UCL#1193
@KrisThielemans KrisThielemans mentioned this issue Aug 20, 2023
Merged
@KrisThielemans
Copy link
Collaborator Author

129 is a weird number for a detector with 128 elements, but that's another issue.

See #1235

@jakirkham jakirkham mentioned this issue Aug 24, 2023
Merged
KrisThielemans added a commit that referenced this issue Aug 25, 2023
@KrisThielemans
fix xy imagesize of FBP SPECTUB image in test
a17e79f 
The code determining the xy image size is sensitive to rounding errors,
so we now say in the .par file what the test expects.

Fixes #1193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix xy imagesize of FBP SPECTUB image in test KrisThielemans/STIR-1
1 participant
@KrisThielemans