Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oyaml recipe #6666

Merged
merged 4 commits into from
Sep 14, 2018
Merged

Add oyaml recipe #6666

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5511608
Add oyaml recipe
bebatut Sep 13, 2018
bb83e73
Fix linting and Bjoern's comment
bebatut Sep 13, 2018
64ecc21
Replace source and remove pyyaml from host req
bebatut Sep 13, 2018
5828430
Update meta.yaml
bgruening Sep 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions recipes/oyaml/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{% set name = "oyaml" %}
{% set version = "0.6" %}

package:
name: "{{ name|lower }}"
version: "{{ version }}"

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: 5064e85aa38ec481b1c49e4941957c6c5e1961291ce276b064c5d6a85d833ec5

build:
number: 0
script: "{{ PYTHON }} -m pip install . --no-deps --ignore-installed -vvv "

requirements:
host:
- pip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one pip

- python
- pyyaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think you need pyyaml as a host requirement since it isn't necessary to build the package.

run:
- python
- pyyaml

test:
imports:
- oyaml

about:
home: https://github.com/wimglenn/oyaml
license: MIT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license_file: LICENSE

license_family: MIT
license_file: LICENSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license_file isn't included in the source distribution, so can you please manually package it:

https://conda-forge.org/docs/meta.html#packaging-the-license-manually

and put the following link to the issue upstream to include the license in the source distribution as a comment in the recipe so that if the issue is fixed upstream, there is a reminder to change the recipe in the feedstock in future releases:

wimglenn/oyaml#12

summary: "Ordered YAML: drop-in replacement for PyYAML which preserves dict ordering"

extra:
recipe-maintainers:
- bebatut