-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oyaml recipe #6666
Add oyaml recipe #6666
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/oyaml:
|
|
||
about: | ||
home: https://github.com/wimglenn/oyaml | ||
license: MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license_file: LICENSE
|
||
requirements: | ||
host: | ||
- pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only one pip
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
home: https://github.com/wimglenn/oyaml | ||
license: MIT | ||
license_family: MIT | ||
license_file: LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license_file
isn't included in the source distribution, so can you please manually package it:
https://conda-forge.org/docs/meta.html#packaging-the-license-manually
and put the following link to the issue upstream to include the license in the source distribution as a comment in the recipe so that if the issue is fixed upstream, there is a reminder to change the recipe in the feedstock in future releases:
recipes/oyaml/meta.yaml
Outdated
host: | ||
- pip | ||
- python | ||
- pyyaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think you need pyyaml
as a host
requirement since it isn't necessary to build the package.
Hi,
This PR is for having oyaml in conda-forge. The
meta.yaml
file has been generated usingconda skeleton pypi oyaml
and tests added afterBérénice