Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oyaml recipe #6666

Merged
merged 4 commits into from
Sep 14, 2018
Merged

Add oyaml recipe #6666

merged 4 commits into from
Sep 14, 2018

Conversation

bebatut
Copy link
Member

@bebatut bebatut commented Sep 13, 2018

Hi,

This PR is for having oyaml in conda-forge. The meta.yaml file has been generated using conda skeleton pypi oyaml and tests added after

Bérénice

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/oyaml) and found some lint.

Here's what I've got...

For recipes/oyaml:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.


about:
home: https://github.com/wimglenn/oyaml
license: MIT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license_file: LICENSE


requirements:
host:
- pip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one pip

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/oyaml) and found it was in an excellent condition.

home: https://github.com/wimglenn/oyaml
license: MIT
license_family: MIT
license_file: LICENSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license_file isn't included in the source distribution, so can you please manually package it:

https://conda-forge.org/docs/meta.html#packaging-the-license-manually

and put the following link to the issue upstream to include the license in the source distribution as a comment in the recipe so that if the issue is fixed upstream, there is a reminder to change the recipe in the feedstock in future releases:

wimglenn/oyaml#12

host:
- pip
- python
- pyyaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think you need pyyaml as a host requirement since it isn't necessary to build the package.

@bgruening bgruening merged commit e45f3ca into conda-forge:master Sep 14, 2018
@bebatut bebatut deleted the oyaml branch September 14, 2018 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants