Add recipe for sarge #3034
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| {% set name = "sarge" %} | ||
| {% set version = "0.1.4" %} | ||
| {% set sha256 = "59f93216723ddd9062d17cbbb90ed9e69267b84825cf0bde0b7f8d934c424823" %} | ||
|
|
||
| package: | ||
| name: {{ name }} | ||
| version: {{ version }} | ||
|
|
||
| source: | ||
| fn: {{ name }}-{{ version }}.tar.gz | ||
| url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz | ||
| sha256: {{ sha256 }} | ||
|
|
||
| build: | ||
| number: 0 | ||
| script: pip install --no-deps . | ||
|
|
||
| requirements: | ||
| build: | ||
| - python | ||
| - pip | ||
|
There was a problem hiding this comment. If installing via |
||
| run: | ||
| - python | ||
|
|
||
| test: | ||
| imports: | ||
| - sarge | ||
|
|
||
| about: | ||
| home: http://sarge.readthedocs.io/en/latest/ | ||
| license: BSD 3-clause | ||
| license_family: BSD | ||
| summary: a wrapper for subprocess for interaction with external applications | ||
| license_file: LICENSE | ||
|
There was a problem hiding this comment. please add: |
||
| doc_url: http://sarge.readthedocs.io/en/latest/ | ||
| dev_url: https://bitbucket.org/vinay.sajip/sarge | ||
|
|
||
| extra: | ||
| recipe-maintainers: | ||
| - takluyver | ||
| - fangohr | ||
|
There was a problem hiding this comment. @fangohr, @mb1a15, @davidcortesortuno are you ok being added as co-maintainers of the There was a problem hiding this comment. Yes. Thanks for processing this so swiftly. |
||
| - mb1a15 | ||
| - davidcortesortuno | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please install via
python setup.py installThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to prefer that over pip? AIUI using pip is always recommended now to install packages. This is also what we do for the ipython feedstock, among a number of other recipes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had not seen the ipython feedstock before and was mainly going off of my experience reviewing other recipes as well as what is explicitly mentioned in the conda-forge docs. I found the following discussion about what should be "standard practice": #528. The conclusion there was not definitive, but it seems like using
pipis ok in the way that you did.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :-)