Add recipe for sarge #3034
Add recipe for sarge #3034
Conversation
We need sarge for some domain specific code we're hoping to use conda- forge to package.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| license: BSD 3-clause | ||
| license_family: BSD | ||
| summary: a wrapper for subprocess for interaction with external applications | ||
| license_file: LICENSE |
There was a problem hiding this comment.
please add:
doc_url: http://sarge.readthedocs.io/en/latest/
dev_url: https://bitbucket.org/vinay.sajip/sarge
|
|
||
| build: | ||
| number: 0 | ||
| script: pip install --no-deps . |
There was a problem hiding this comment.
Please install via python setup.py install
There was a problem hiding this comment.
Is there a reason to prefer that over pip? AIUI using pip is always recommended now to install packages. This is also what we do for the ipython feedstock, among a number of other recipes.
There was a problem hiding this comment.
I had not seen the ipython feedstock before and was mainly going off of my experience reviewing other recipes as well as what is explicitly mentioned in the conda-forge docs. I found the following discussion about what should be "standard practice": #528. The conclusion there was not definitive, but it seems like using pip is ok in the way that you did.
| requirements: | ||
| build: | ||
| - python | ||
| - pip |
There was a problem hiding this comment.
If installing via setup.py remove pip.
| extra: | ||
| recipe-maintainers: | ||
| - takluyver | ||
| - fangohr |
There was a problem hiding this comment.
@fangohr, @mb1a15, @davidcortesortuno are you ok being added as co-maintainers of the sarge package on conda-forge?
There was a problem hiding this comment.
Yes. Thanks for processing this so swiftly.
|
Thanks @synapticarbors for the prompt review on our PRs, by the way. :-) |
We need sarge for some domain specific code we're hoping to use conda-forge to package.