Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add func-adl #27541

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Sep 10, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [N/A] If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/func-adl/meta.yaml) and found some lint.

Here's what I've got...

For recipes/func-adl/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: gordonwatts. Please ask them to comment on this PR if they are.

For recipes/func-adl/meta.yaml:

  • No valid build backend found for Python recipe for package func-adl using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/func-adl/meta.yaml) and found some lint.

Here's what I've got...

For recipes/func-adl/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: gordonwatts. Please ask them to comment on this PR if they are.

@matthewfeickert
Copy link
Member Author

matthewfeickert commented Sep 10, 2024

@gordonwatts can I please get you to sign off with a comment in the same way that you did for #25914?

(Once this is merged and has a feedstock I'll turn on automerge for passing builds so you don't have to do anything for future releases. c.f. conda-forge/make-it-sync-feedstock#1)

@matthewfeickert
Copy link
Member Author

@gordonwatts ping on this.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/func-adl/meta.yaml) and found it was in an excellent condition.

@xhochy
Copy link
Member

xhochy commented Sep 22, 2024

@matthewfeickert in cases where someone doesn't reply, it is common to remove them from the recipe and add them later on the feedstock.

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/func-adl/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: gordonwatts. Please ask them to comment on this PR if they are.

@matthewfeickert
Copy link
Member Author

matthewfeickert commented Sep 22, 2024

@xhochy thanks. I'm in transit now but I'll remove @gordonwatts if he doesn't respond by this evening and then rebase and rerender this PR and tag for review.

edit: I've removed @gordonwatts to get this merged and will then add him on as a maintainer once the feedstock is up.

* c.f. https://github.com/iris-hep/func_adl
* Recipe generated with grayskull via 'grayskull pypi func-adl'
  and then edited to add additional information.
* MNT: Add setuptools to host as no build-system
@matthewfeickert
Copy link
Member Author

@conda-forge/help-python, ready for review!

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@ocefpaf ocefpaf merged commit f591ece into conda-forge:main Sep 23, 2024
6 checks passed
@matthewfeickert matthewfeickert deleted the feat/add-func-adl branch September 23, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants