-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to conda-forge #352
Comments
conda-forge/staged-recipes#25848 added https://github.com/conda-forge/miniopy-async-feedstock so |
Now just missing $ grayskull pypi --list-missing-deps --strict-conda-forge 'servicex==3.0.0a15'
#### Initializing recipe for servicex==3.0.0a15 (pypi) ####
Recovering metadata from pypi...
Starting the download of the sdist package servicex
servicex 100% Time: 0:00:00 4.9 MiB/s|#################################################################################################################################################################|
Checking for pyproject.toml
pyproject.toml found in /tmp/grayskull-servicex-w83ffbke/servicex-3.0.0a15/pyproject.toml
Recovering information from setup.py
Executing injected distutils...
Checking >> types-pyyaml 100% |####################################################################################################################################################|[Elapsed Time: 0:00:06]
Recovering license info from spdx.org ...
Matching license file with database from Grayskull...
Match percentage of the license is 97%. Low match percentage could mean that the license was modified.
License type: BSD-3-Clause
License file: ['LICENSE']
Build requirements:
<none>
Host requirements:
- python >=3.8
- hatchling >=1.13.0
- pip
Run requirements:
- python >=3.8
- qastle >=0.17
- func-adl >=3.2.6
- requests >=2.31
- pydantic >=1.10,<2.0
- httpx >=0.24
- miniopy-async >=1.15
- tinydb >=4.7
- google-auth >=2.17
- typer >=0.9.0
- pyyaml >=6.0
- types-pyyaml >=6.0
- rich >=13.0.0
- aiofile
- make-it-sync
RED: Missing packages
GREEN: Packages available on conda-forge
Missing dependencies: func-adl, qastle
Maintainers:
- matthewfeickert
#### Recipe generated on /tmp for servicex==3.0.0a15 ####
$ with PRs opened to help address this: |
Quick question about this, @matthewfeickert - these are pure python packages - what is the advantage of also maintaining a package there, vs. just having them in |
@gordonwatts Good questions.
Conda requires all dependency packages to already exist somewhere as conda-packages for you to be able to package something as a conda package. So to be able to package the serviceX client you need all its dependencies on conda-forge. As to "why package the serviceX client on conda-forge at all if it is pure-Python?", the only conda package manager that truly resolves things with equal parity between conda package indexes (e.g. conda-forge) and It is true that in most situations in which you're dealing with things on PyPI you're not going to run into problems, but providing these simple repackagings also cuts down on (or fully eliminates) the package resolution that your package manager of choice needs to do between the different metadata trees. So this is not necessary, but it does makes things easier, especially the more complex an environment gets where incorrect solves can start to happen.
Not really (though I mean, yes, that is just a true statement about things). Even if the human in the loop reviewing the autogenerated PRs is considered the problem/blocker here you can enable automerge so that conda-forge just keeps your tools updated as long as they build. It is perhaps better to think about having a package feedstock on conda-forge being controls that you hook into the conda-forge framework than what we do with distributing packages to PyPI where you have to come with your own packaging system and then just distribute the resulting artifacts. I will give you though that if you have a complex system like |
conda-forge/staged-recipes#26178 has been merged and so there is now https://github.com/conda-forge/qastle-feedstock. The only remaining thing is for @gordonwatts to make a new |
Now everything is on conda-forge, but edit: Ah want to use https://github.com/conda-forge/ruamel.yaml-feedstock/ instead. |
Adding with conda-forge/staged-recipes#27997 |
It would be nice to also have IRIS-HEP tools available on conda-forge.
For
servicex
there's some additional work in other areas though that would be required as usinggrayskull
to check we findthat
qastle
,make-it-sync
,func-adl
,miniopy-async
are all missing from conda-forge.I can follow up with @gordonwatts and @masonproffitt on if they're okay with me packaging
func-adl
,qastle
, andmake-it-sync
for conda-forge.miniopy-async
isn't missing any packages, so we could ask if they would consider distributing on conda-forge too. (Done in hlf20010508/miniopy-async#25)The text was updated successfully, but these errors were encountered: