Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add R volumodel rangebuilder and modeva #26896

Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jul 10, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-modeva, recipes/r-rangebuilder, recipes/r-volumodel) and found some lint.

Here's what I've got...

For recipes/r-modeva:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

For recipes/r-rangebuilder:

  • There are too few lines. There should be one empty line at the end of the file.
  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

For recipes/r-volumodel:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@ocefpaf ocefpaf marked this pull request as ready for review July 10, 2024 08:43
@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 10, 2024

@conda-forge/r, @conda-forge/help-r this one is ready for review.

The missing r-terra should be fine b/c the r-modeva is noarch.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-modeva, recipes/r-rangebuilder, recipes/r-volumodel) and found some lint.

Here's what I've got...

For recipes/r-modeva:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

For recipes/r-rangebuilder:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

For recipes/r-volumodel:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 10, 2024

@mfansler another one if you have the time. I did run conda_r_skeleton_helper in the last commit to make things a bit easier.

Copy link
Member

@mfansler mfansler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All look good - thanks! ❤️

@ocefpaf ocefpaf mentioned this pull request Jul 10, 2024
10 tasks
@ocefpaf ocefpaf force-pushed the add_R-volumodel_rangebuilder_and_modeva branch from 390bc39 to 9b59114 Compare July 10, 2024 10:38
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-rangebuilder, recipes/r-volumodel) and found some lint.

Here's what I've got...

For recipes/r-rangebuilder:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

For recipes/r-volumodel:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 10, 2024

@mfansler should be good for another pass!

Copy link
Member

@mfansler mfansler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. With the new UCRT + R 4.4 rolling out, there is a better possibility of getting r-terra > 1.5_50 building for windows as well. So that might start working eventually.

@mfansler mfansler merged commit adeedd9 into conda-forge:main Jul 10, 2024
2 of 5 checks passed
@ocefpaf ocefpaf deleted the add_R-volumodel_rangebuilder_and_modeva branch July 11, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants