-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opentrons
recipes
#15705
Add opentrons
recipes
#15705
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/opentrons:
For recipes/opentrons_shared_data:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/opentrons:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
The 'pip check' command executed only for Linux as it fails on check due to a missing 'aionotify' on other platforms.
@conda-forge/staged-recipes, ready for your review. |
FYI: the suggested patch in Opentrons/opentrons#8154 was merged by the code developers. The build commands are based on the steps in https://github.com/Opentrons/opentrons/blob/edge/Dockerfile, that's why I had to build wheels first, and then install from them. Is there anything I can do to improve it? I'd like to have it merged soon, as it's a missing dependency of conda-forge/lixtools-feedstock#1 that was not discovered during our work on #15648 with @kbeeperez. |
I see one improvement that can be done: combining two |
The matplotlib feedstock has a decent example of how to handle it. You can have the different sets of build scripts under different names and manually list them in |
This is a really good example from my co-worker, thanks @dopplershift! I see how it can be done now and will work on it tomorrow. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@dopplershift, ready for your review! Thanks. |
@conda-forge/staged-recipes, ready for review! conda-forge/lixtools-feedstock#1 needs this missing dependency. Thank you. |
@conda-forge/staged-recipes friends, could this please be merged soon? We plan to test the packages at NSLS-II next week (Wednesday, August 4), it would be great to have the packages from this PR available. Thanks a lot for your cooperation and help! |
Thank you, @dopplershift! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).