Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opentrons recipes #15705

Merged
merged 26 commits into from
Aug 2, 2021
Merged

Add opentrons recipes #15705

merged 26 commits into from
Aug 2, 2021

Conversation

mrakitin
Copy link
Member

@mrakitin mrakitin commented Jul 20, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/opentrons, recipes/opentrons_shared_data) and found some lint.

Here's what I've got...

For recipes/opentrons:

  • The summary item is expected in the about section.
  • requirements: run: pydantic==1.4 must contain a space between the name and the pin, i.e. pydantic ==1.4

For recipes/opentrons_shared_data:

  • The summary item is expected in the about section.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/opentrons, recipes/opentrons_shared_data) and found some lint.

Here's what I've got...

For recipes/opentrons:

  • requirements: run: pydantic==1.4 must contain a space between the name and the pin, i.e. pydantic ==1.4

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/opentrons, recipes/opentrons_shared_data) and found it was in an excellent condition.

@mrakitin mrakitin changed the title Add opentrons recipes Add opentrons recipes Jul 23, 2021
@mrakitin
Copy link
Member Author

@conda-forge/staged-recipes, ready for your review.

@mrakitin mrakitin mentioned this pull request Jul 25, 2021
9 tasks
@mrakitin
Copy link
Member Author

FYI: the suggested patch in Opentrons/opentrons#8154 was merged by the code developers.

The build commands are based on the steps in https://github.com/Opentrons/opentrons/blob/edge/Dockerfile, that's why I had to build wheels first, and then install from them.

Is there anything I can do to improve it? I'd like to have it merged soon, as it's a missing dependency of conda-forge/lixtools-feedstock#1 that was not discovered during our work on #15648 with @kbeeperez.

@mrakitin
Copy link
Member Author

I see one improvement that can be done: combining two meta.yaml files into one as it uses the same source. But I am not sure how to properly do it with the outputs feature. Do you have any good examples where it's done, so that I could use it here too? Not sure how to deal with two sets of build.sh & bld.bat in this case though... Suggestions are welcome and highly appreciated.

@dopplershift
Copy link
Member

The matplotlib feedstock has a decent example of how to handle it. You can have the different sets of build scripts under different names and manually list them in meta.yaml.

@mrakitin
Copy link
Member Author

This is a really good example from my co-worker, thanks @dopplershift! I see how it can be done now and will work on it tomorrow.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/opentrons) and found it was in an excellent condition.

@mrakitin
Copy link
Member Author

@dopplershift, ready for your review! Thanks.

@mrakitin
Copy link
Member Author

@conda-forge/staged-recipes, ready for review! conda-forge/lixtools-feedstock#1 needs this missing dependency. Thank you.

@mrakitin
Copy link
Member Author

@conda-forge/staged-recipes friends, could this please be merged soon? We plan to test the packages at NSLS-II next week (Wednesday, August 4), it would be great to have the packages from this PR available. Thanks a lot for your cooperation and help!

@dopplershift dopplershift merged commit ff0bc10 into conda-forge:master Aug 2, 2021
@mrakitin mrakitin deleted the opentrons branch August 2, 2021 21:29
@mrakitin
Copy link
Member Author

mrakitin commented Aug 2, 2021

Thank you, @dopplershift!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants