adding lixtools recipe

[kbeeperez]

implements:
https://github.com/nsls-ii-forge/lixtools-feedstock
https://github.com/nsls-ii-forge/py4xs-feedstock

Checklist

• Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
• License file is packaged (see here for an example).
• Source is from official source.
• Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
• If static libraries are linked in, the license of the static library is packaged.
• Build number is 0.
• A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
• GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
• When in trouble, please check our knowledge base documentation before pinging a team.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/lixtools) and found it was in an excellent condition.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/lixtools, recipes/py4xs) and found it was in an excellent condition.

[kbeeperez]

Attn @mrakitin

[mrakitin]

Looks good overall, I added a comment on how to solve the Windows tests that are currently excluded.

[mrakitin]

Looks good to me!

@conda-forge/staged-recipes, I agree to be a maintainer of these feedstocks/packages.

[dopplershift]

@lyang11973 are you ok with being listed as a maintainer for both of these recipes?

[lyang11973]

Not sure what I need to do. But sure, I agree to be a maintainer.

…

On Fri, Jul 16, 2021 at 10:43 AM Maksim Rakitin ***@***.***> wrote: ***@***.**** requested changes on this pull request. Looks good overall, I added a comment on how to solve the Windows tests that are currently excluded. ------------------------------ In recipes/lixtools/meta.yaml <#15648 (comment)> : > + - python >=3.6 + - matplotlib + - numpy + - openpyxl >=3 + - pandas + - pillow + - py4xs + - python-barcode + - qrcode + +test: + imports: + - lixtools + commands: # [not win] + - python -c 'import os, pkg_resources; assert os.path.isfile(pkg_resources.resource_filename("lixtools", "plate_label_template.html"))' # [not win] + - python -c 'import os, pkg_resources; assert os.path.isfile(pkg_resources.resource_filename("lixtools", "template_report.ipynb"))' # [not win] I am against excluding tests for Windows. Could you try to fix it instead? On Windows CLI, single quotes are not accepted. Please use double-quotes. An easy way to test it on your Windows machine is to install the package locally and try this python -c ... string. ------------------------------ In recipes/lixtools/meta.yaml <#15648 (comment)> : > +test: + imports: + - lixtools + commands: # [not win] + - python -c 'import os, pkg_resources; assert os.path.isfile(pkg_resources.resource_filename("lixtools", "plate_label_template.html"))' # [not win] + - python -c 'import os, pkg_resources; assert os.path.isfile(pkg_resources.resource_filename("lixtools", "template_report.ipynb"))' # [not win] + +about: + home: https://github.com/NSLS-II-LIX/lixtools + license: BSD-3-Clause + license_file: LICENSE + summary: Software tools for data collection/processing at NSLS-II LiX + +extra: + recipe-maintainers: + - mrakitin Adding @lyang11973 <https://github.com/lyang11973> as a core developer of the package. Lin, do you agree to be a maintainer of this conda-forge feedstock? ⬇️ Suggested change - - mrakitin + - lyang11973 + - mrakitin ------------------------------ In recipes/py4xs/meta.yaml <#15648 (comment)> : > + - scipy + +test: + imports: + - py4xs + +about: + home: https://pypi.org/project/py4xs + license: MIT + license_file: LICENSE.txt + summary: py4xs - a python package for processing x-ray scattering data + dev_url: https://github.com/NSLS-II-LIX/py4xs + +extra: + recipe-maintainers: + - mrakitin ⬇️ Suggested change - - mrakitin + - lyang11973 + - mrakitin — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15648 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFNJXD4CFOGVZJKGOTI3Z33TYBARBANCNFSM5AO3CE6Q> .

[dopplershift]

@lyang11973 You'll receive GitHub notifications about issues and PRs on the repositories that hold the recipes (the information that's used to build a package for lixtools/py4xs on conda-forge).

[mrakitin]

@dopplershift, do you know why the final checks before merging did not run the tests? The resulting feedstock with more tests (added here via 5b2c036) uncovered missing dependencies (in particular, opentrons, that I am working on within #15705).

[dopplershift]

No, and 🐑 that I missed it.