Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jpegturbo Issue 18 #20

Merged
merged 17 commits into from
Apr 5, 2023
Merged

jpegturbo Issue 18 #20

merged 17 commits into from
Apr 5, 2023

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Apr 4, 2023 •
edited by mfansler
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@hmaarrfk hmaarrfk requested review from a team and croth1 as code owners April 4, 2023 22:29
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk hmaarrfk mentioned this pull request Apr 4, 2023
Merged
4 tasks
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Apr 4, 2023

I guess it isn't so much about being "smart" as it working around issues i've seen before with conda_config_yaml

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Apr 4, 2023

i think that zipping keys, that are in the middle of migrations is just buggy.

mfansler
mfansler reviewed Apr 5, 2023
View reviewed changes
.ci_support/osx_64_r_base4.1.yaml Show resolved Hide resolved
conda-forge.yml Outdated Show resolved Hide resolved
recipe/meta.yaml
Comment on lines +46 to +50
{% if r_base == "4.1" %}
- jpeg 9
{% else %}
- libjpeg-turbo
{% endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Apparently, this also has the advantage of not triggering the linter bug.

@mfansler
Copy link
Member

mfansler commented Apr 5, 2023

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Apr 5, 2023

I never asked:

is there some incompatibility between r 4.1 and turbo? turbo is pretty widely used.

@mfansler
Copy link
Member

mfansler commented Apr 5, 2023

I never asked:

is there some incompatibility between r 4.1 and turbo? turbo is pretty widely used.

The migration is failing for other reasons (Windows no longer builds). The splitting here is just temporary until that moves forward.

@mfansler mfansler added the automerge Merge the PR when CI passes label Apr 5, 2023
@mfansler
Copy link
Member

mfansler commented Apr 5, 2023

@hmaarrfk thanks so much for the help on this! Very enlightening to see some more advanced tricks-of-the-trade in action.

@github-actions github-actions bot merged commit 6ad2b57 into conda-forge:main Apr 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@mfansler mfansler mentioned this pull request May 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfansler mfansler mfansler approved these changes

@croth1 croth1 Awaiting requested review from croth1 croth1 is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmaarrfk @mfansler