Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declare libjpeg dep #19

Merged
merged 10 commits into from
Apr 5, 2023
Merged

declare libjpeg dep #19

merged 10 commits into from
Apr 5, 2023

Conversation

mfansler
Copy link
Member

@mfansler mfansler commented Apr 4, 2023

Adds explicitly libjpeg dependency. Since r-base=4.1 has not yet migrated, we split the declaration via variants.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Partially addresses #18.

@mfansler mfansler requested review from a team and croth1 as code owners April 4, 2023 01:13
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@mfansler
Copy link
Member Author

mfansler commented Apr 4, 2023

@conda-forge-admin please rerender

@mfansler
Copy link
Member Author

mfansler commented Apr 4, 2023

The linter failure is expected, due to open bug: conda-forge/conda-smithy#1726.

@mfansler
Copy link
Member Author

mfansler commented Apr 4, 2023

@conda-forge-admin please rerender

@mfansler
Copy link
Member Author

mfansler commented Apr 4, 2023

Seeing clobber warnings both from this build (seems like vendoring deps) and from libjpeg-turbo + jpeg coinstallation.

@mfansler mfansler marked this pull request as draft April 4, 2023 02:39
@mfansler
Copy link
Member Author

mfansler commented Apr 4, 2023

@conda-forge-admin please rerender

@mfansler
Copy link
Member Author

mfansler commented Apr 4, 2023

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Apr 4, 2023

copy in the migration file for jpeg9->jpeg turbo. it adds a stricter pin on turbo with the exclusion

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Apr 4, 2023

The transition isn't super easy... yet, see final point conda-forge/conda-forge.github.io#673 (comment)

@mfansler
Copy link
Member Author

mfansler commented Apr 4, 2023

@conda-forge-admin please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/r-cairo-feedstock/actions/runs/4612439208.

@mfansler
Copy link
Member Author

mfansler commented Apr 4, 2023

@hmaarrfk thanks for the quick reply! Where should I copy it to? I tried .ci_support/migrations/, but rerender bot found nothing to do. I expect it should update the pins in the .ci_support/*.yaml files.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Apr 4, 2023

Try: mfansler#1

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Apr 4, 2023

lets see what happens in #20

@github-actions github-actions bot merged commit aefea69 into conda-forge:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants