Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for CUDNN9, remove python 3.8 #18

Closed
wants to merge 7 commits into from
Closed

Rebuild for CUDNN9, remove python 3.8 #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
10ad587
dummy commit for rerendering
conda-forge-webservices[bot] Oct 8, 2024
0c1553d
Cleanup recipe and bump build number
hmaarrfk Oct 8, 2024
259805b
Create cudnn9.yaml
hmaarrfk Oct 8, 2024
3481e37
MNT: Re-rendered with conda-build 24.9.0, conda-smithy 3.41.1, and co…
Oct 8, 2024
838c554
Revert "MNT: Re-rendered with conda-build 24.9.0, conda-smithy 3.41.1…
weiji14 Oct 13, 2024
61d90a6
Set cudnn9 migrator build number to 2
weiji14 Oct 13, 2024
31359b9
MNT: Re-rendered with conda-build 24.9.0, conda-smithy 3.42.1, and co…
weiji14 Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 24 additions & 36 deletions .azure-pipelines/azure-pipelines-linux.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 9 additions & 12 deletions .azure-pipelines/azure-pipelines-osx.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

48 changes: 0 additions & 48 deletions ...lernvcccuda_compiler_version11.8cxx_compiler_version11numpy1.22python3.8.____cpython.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...sion11numpy2.0python3.10.____cpython.yaml → ...iler_version11python3.10.____cpython.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cuda_compiler:
cuda_compiler_version:
- '11.8'
cudnn:
- '8'
- '9'
cxx_compiler:
- gxx
cxx_compiler_version:
Expand Down
2 changes: 1 addition & 1 deletion ...sion11numpy2.0python3.11.____cpython.yaml → ...iler_version11python3.11.____cpython.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cuda_compiler:
cuda_compiler_version:
- '11.8'
cudnn:
- '8'
- '9'
cxx_compiler:
- gxx
cxx_compiler_version:
Expand Down
2 changes: 1 addition & 1 deletion ...sion11numpy2.0python3.12.____cpython.yaml → ...iler_version11python3.12.____cpython.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cuda_compiler:
cuda_compiler_version:
- '11.8'
cudnn:
- '8'
- '9'
cxx_compiler:
- gxx
cxx_compiler_version:
Expand Down
2 changes: 1 addition & 1 deletion ...rsion11numpy2.0python3.9.____cpython.yaml → ...piler_version11python3.9.____cpython.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cuda_compiler:
cuda_compiler_version:
- '11.8'
cudnn:
- '8'
- '9'
cxx_compiler:
- gxx
cxx_compiler_version:
Expand Down
48 changes: 0 additions & 48 deletions ...da-nvcccuda_compiler_version12.0cxx_compiler_version12numpy1.22python3.8.____cpython.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...sion12numpy2.0python3.10.____cpython.yaml → ...iler_version12python3.10.____cpython.yaml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build for CUDA 12.0 / Python 3.10 is failing because torchvision has a single build failure after conda-forge/torchvision-feedstock#98. @hmaarrfk, could you retry the build at https://github.com/conda-forge/torchvision-feedstock/runs/31170635359? Or we can wait for conda-forge/torchvision-feedstock#99

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restarted.

Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cuda_compiler:
cuda_compiler_version:
- '12.0'
cudnn:
- '8'
- '9'
cxx_compiler:
- gxx
cxx_compiler_version:
Expand Down
2 changes: 1 addition & 1 deletion ...sion12numpy2.0python3.11.____cpython.yaml → ...iler_version12python3.11.____cpython.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cuda_compiler:
cuda_compiler_version:
- '12.0'
cudnn:
- '8'
- '9'
cxx_compiler:
- gxx
cxx_compiler_version:
Expand Down
2 changes: 1 addition & 1 deletion ...sion12numpy2.0python3.12.____cpython.yaml → ...iler_version12python3.12.____cpython.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cuda_compiler:
cuda_compiler_version:
- '12.0'
cudnn:
- '8'
- '9'
cxx_compiler:
- gxx
cxx_compiler_version:
Expand Down
2 changes: 1 addition & 1 deletion ...rsion12numpy2.0python3.9.____cpython.yaml → ...piler_version12python3.9.____cpython.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cuda_compiler:
cuda_compiler_version:
- '12.0'
cudnn:
- '8'
- '9'
cxx_compiler:
- gxx
cxx_compiler_version:
Expand Down
48 changes: 0 additions & 48 deletions ...lerNonecuda_compiler_versionNonecxx_compiler_version13numpy1.22python3.8.____cpython.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...sion13numpy2.0python3.10.____cpython.yaml → ...iler_version13python3.10.____cpython.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cuda_compiler:
cuda_compiler_version:
- None
cudnn:
- '8'
- '9'
cxx_compiler:
- gxx
cxx_compiler_version:
Expand Down
2 changes: 1 addition & 1 deletion ...sion13numpy2.0python3.11.____cpython.yaml → ...iler_version13python3.11.____cpython.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cuda_compiler:
cuda_compiler_version:
- None
cudnn:
- '8'
- '9'
cxx_compiler:
- gxx
cxx_compiler_version:
Expand Down
2 changes: 1 addition & 1 deletion ...sion13numpy2.0python3.12.____cpython.yaml → ...iler_version13python3.12.____cpython.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cuda_compiler:
cuda_compiler_version:
- None
cudnn:
- '8'
- '9'
cxx_compiler:
- gxx
cxx_compiler_version:
Expand Down
2 changes: 1 addition & 1 deletion ...rsion13numpy2.0python3.9.____cpython.yaml → ...piler_version13python3.9.____cpython.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ cuda_compiler:
cuda_compiler_version:
- None
cudnn:
- '8'
- '9'
cxx_compiler:
- gxx
cxx_compiler_version:
Expand Down
8 changes: 8 additions & 0 deletions .ci_support/migrations/cudnn9.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
__migrator:
build_number: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found out why, the build_number in this migrator was set to 1 previously at commit 259805b. I've bumped it to 2 at commit 61d90a6 and re-rerendered.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmaarrfk - do you have a clue what's going on here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was just a copy-paste error. @hmaarrfk copied the cudnn9.yaml file from somewhere that set build_number: 1, when it should have been build_number: 2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think build_number: 1 is how it's done usually – it's an increment in the build_number.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think build_number: 1 is how it's done usually – it's an increment in the build_number.

Hmm ok. I did a quick search and found https://github.com/regro/cf-scripts/blob/621910b1438b5ed2f3510fc72c7f692ac4e2ed5a/README.md?plain=1#L99-L103, which has a comment that says build_number determines the increment, but then the actual uncommented line says bump_number: 1 😕

commit_message: Rebuild for cudnn 9
kind: version
migration_number: 1
cudnn:
- '9'
migrator_ts: 1724175586.3831317
Loading
Loading