-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for CUDNN9, remove python 3.8 #18
Rebuild for CUDNN9, remove python 3.8 #18
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.10.07.21.36.54
I think the bot was stuck. |
Not really seeing where CUDNN9 is being set, will that be in a follow-up PR actually (hence why the build number isn't bumped to 1)? Edit: Oh, I see the bot deleted the |
Very odd. The bot removes the migration file, and cudnn is still pinned to 8 .. |
…, and conda-forge-pinning 2024.10.07.21.36.54" This reverts commit 3481e37.
…nda-forge-pinning 2024.10.12.13.15.35
@@ -0,0 +1,8 @@ | |||
__migrator: | |||
build_number: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hmaarrfk - do you have a clue what's going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was just a copy-paste error. @hmaarrfk copied the cudnn9.yaml
file from somewhere that set build_number: 1
, when it should have been build_number: 2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think build_number: 1
is how it's done usually – it's an increment in the build_number
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
build_number: 1
is how it's done usually – it's an increment in thebuild_number
.
Hmm ok. I did a quick search and found https://github.com/regro/cf-scripts/blob/621910b1438b5ed2f3510fc72c7f692ac4e2ed5a/README.md?plain=1#L99-L103, which has a comment that says build_number
determines the increment, but then the actual uncommented line says bump_number: 1
😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build for CUDA 12.0 / Python 3.10 is failing because torchvision
has a single build failure after conda-forge/torchvision-feedstock#98. @hmaarrfk, could you retry the build at https://github.com/conda-forge/torchvision-feedstock/runs/31170635359? Or we can wait for conda-forge/torchvision-feedstock#99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restarted.
See #19 |
Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #17.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.
Fixes #17