-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pytorch-cpu/gpu build only for single python version #282
Fix pytorch-cpu/gpu build only for single python version #282
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
ce32d55
to
35cba95
Compare
aarch64 + cuda 12.0 build failed: linux_aarch64_c_compiler_version12c_stdlib_version2.28cuda_compilercuda-nvcccuda_compiler_version12.0cxx_compiler_version12-log.zip
|
Co-authored-by: Mark Harfouche <[email protected]>
here goes an other 2 hours..... |
and Build log: log_linux64_mkl_cpu.zip |
Wait, perhaps this is the expected behavior (not specific to any python version). If so, it appears to be working as intended. I'll continue building... |
Still building, but the estimated time to completion is 4-5 hours. Packages that have been built so far: |
Correct, this is the expected behavior. When the megabuild happens a single The old used
|
I'm sorry to say this, but I think it might be good to include this patch: It is manifesting as a failure in conda-forge/torchvision-feedstock#102 |
- {{ pin_subpackage("pytorch", exact=True) }} | ||
- pytorch {{ version }}=cuda*{{ PKG_BUILDNUM }} # [megabuild and cuda_compiler_version != "None"] | ||
- pytorch {{ version }}=cpu_{{ blas_impl }}*{{ PKG_BUILDNUM }} # [megabuild and cuda_compiler_version == "None"] | ||
- {{ pin_subpackage("pytorch", exact=True) }} # [not megabuild] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might want to remove this line, otherwise you'll fix to a python version for non-megabuild variants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The non megabuillds should have multiple packags created. Is that not the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, ok. I'm sure you're right, I need to check more carefully I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still getting familiar with your recipe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The megabuilds were created since before the large runner from quantsigh hour builds, we used to HAVE to build locally. And it would effectively save me a 12 hours of rebuilding libtorch 4 times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I guess "megabuild" = 1 x libtorch and 5 x python bindings/code, as opposed to 5 x normal builds (libtorch + bindings + python code)?
The build is done! Log: log_files_1.zip, log_files_2.zip |
|
Resolves #281
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)