-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyTorch 2.5.1 #277
PyTorch 2.5.1 #277
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11393752191. |
ee95e8c
to
5559a7e
Compare
You might need to update my patch to help find numpy, my suggestion didn't seem like it went through upstream.... |
0dffeb2
to
cd1d246
Compare
Submitted pytorch/pytorch#138287 for the nvtx patch |
Woohoo, it passed the cmake configuration stage and is now in building stage. By the way, I don't have permissions to run several CI jobs. Could I get those permissions or would someone like to take over this PR or create a new one? |
just use azure for now, that CI gets cloggled anyway, then you wait for ever ;) |
if you can get to the 6 hour timeout, we can switch back to the larger runner |
@conda-forge-admin, please rerender |
1 similar comment
@conda-forge-admin, please rerender |
@conda-forge-admin, please rerender |
There are other things you have to patch out.
|
213cb75
to
1b40828
Compare
This is totally fine to me as long as we can move forward! |
@conda-forge-admin please rerender |
Honestly, feel free to clean up the commigts and force push:
Then if you have a few powerful linux machines, you can run the builds yourself. |
Co-authored-by: Mark Harfouche <[email protected]>
7c5b2fe
to
a044aec
Compare
Done! I've squashed all the commits into one with co-authoring. Also, I've initiated a local build for Linux. Once it's complete, how can I upload the files (if needed)? They will be too large to attach to this PR comment thread. |
Should we create an issue in https://github.com/Quansight/open-gpu-server/issues to request an image with more disk space, to avoid having to do CFEP03 in the future? |
@Tobias-Fischer sounds good! Quansight/open-gpu-server#47 |
You should upload them to your own anaconda channel as outlined in CFPE03 |
The logs should be uploaded here for me and others to review |
a044aec
to
55d6088
Compare
…nda-forge-pinning 2024.11.01.21.49.52
55d6088
to
f0df7dc
Compare
the linker script strikes again! |
Alright, I just finished building Linux packages locally with the linker script patch (which I'm not 100% sure if it's a proper fix, though): |
I was about to upload but then i realized that the That said this seems to be a problem with the 2.4.1 package as well and likely for many of the lets merge this and find a longer term solution later. |
OMG, this got merged! 🎉 🎉 Thank you so much for all your help! For the pytorch-cpu package, what would be the desired outcome? |
That users can install it with ay python version. Right now it locks them to a single one. |
yeah, if you use pin_subpackage with exact=True, it'll pin to the python version.
|
I will have a look as soon as I can :) |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)