Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux -> windows cross-compilation #187

Merged
merged 33 commits into from
Oct 26, 2023

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Oct 16, 2023

Closes #183

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@pavelzw
Copy link
Member Author

pavelzw commented Oct 17, 2023

@conda-forge-admin, please rerender

@0xbe7a
Copy link
Member

0xbe7a commented Oct 20, 2023

@0xbe7a
Copy link
Member

0xbe7a commented Oct 26, 2023

@conda-forge-admin, please restart ci

@pavelzw pavelzw marked this pull request as ready for review October 26, 2023 10:46
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we merge, we should definitely rerender this to ensure that nothing breaks other systems.

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@pavelzw
Copy link
Member Author

pavelzw commented Oct 26, 2023

You can install the builds from 45450e1 (#187) using

micromamba install -c https://repo.prefix.dev/test-polars polars=0.19.11

@pavelzw
Copy link
Member Author

pavelzw commented Oct 26, 2023

I did some light testing with the cross-compiled build and everything seems to work 👍🏻

@pavelzw
Copy link
Member Author

pavelzw commented Oct 26, 2023

Tested the newest build ✅
micromamba install -c https://repo.prefix.dev/test-polars2 polars=0.19.11

@xhochy
Copy link
Member

xhochy commented Oct 26, 2023

We will need conda-forge/clang-win-activation-feedstock#31 to get rid of

2023-10-26T13:47:26.8314466Z WARNING (polars,lib/site-packages/polars/polars.pyd): Needed DSO api-ms-win-crt-stdio-l1-1-0.dll found in ['ucrt']
2023-10-26T13:47:26.8319964Z WARNING (polars,lib/site-packages/polars/polars.pyd): .. but ['ucrt'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
2023-10-26T13:47:26.8322721Z WARNING (polars,lib/site-packages/polars/polars.pyd): Needed DSO api-ms-win-crt-heap-l1-1-0.dll found in ['ucrt']
2023-10-26T13:47:26.8324106Z WARNING (polars,lib/site-packages/polars/polars.pyd): .. but ['ucrt'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
2023-10-26T13:47:26.8330566Z WARNING (polars,lib/site-packages/polars/polars.pyd): Needed DSO api-ms-win-crt-runtime-l1-1-0.dll found in ['ucrt']
2023-10-26T13:47:27.8297454Z WARNING (polars,lib/site-packages/polars/polars.pyd): .. but ['ucrt'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
2023-10-26T13:47:27.8299486Z WARNING (polars,lib/site-packages/polars/polars.pyd): Needed DSO api-ms-win-crt-convert-l1-1-0.dll found in ['ucrt']
2023-10-26T13:47:27.8306434Z WARNING (polars,lib/site-packages/polars/polars.pyd): .. but ['ucrt'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
2023-10-26T13:47:27.8307935Z WARNING (polars,lib/site-packages/polars/polars.pyd): Needed DSO api-ms-win-crt-string-l1-1-0.dll found in ['ucrt']
2023-10-26T13:47:27.8309333Z WARNING (polars,lib/site-packages/polars/polars.pyd): .. but ['ucrt'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
2023-10-26T13:47:27.8313485Z WARNING (polars,lib/site-packages/polars/polars.pyd): Needed DSO api-ms-win-crt-math-l1-1-0.dll found in ['ucrt']
2023-10-26T13:47:27.8314925Z WARNING (polars,lib/site-packages/polars/polars.pyd): .. but ['ucrt'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

@0xbe7a
Copy link
Member

0xbe7a commented Oct 26, 2023

@conda-forge-admin, please restart ci

@0xbe7a 0xbe7a added the automerge Merge the PR when CI passes label Oct 26, 2023
@0xbe7a 0xbe7a merged commit 18b0e4a into conda-forge:main Oct 26, 2023
@0xbe7a 0xbe7a deleted the activate-win-builds branch October 26, 2023 17:01
@pavelzw pavelzw mentioned this pull request Oct 27, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polars >= 0.19.7 not buildable on windows azure runners.
3 participants