Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont enable cross-compile feature #109

Merged
merged 3 commits into from
Oct 22, 2023
Merged

Conversation

0xbe7a
Copy link
Member

@0xbe7a 0xbe7a commented Oct 20, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Maturin uses cargo-xwin by default when compiling from Linux to x86_64_pc_windows_msvc. cargo-xwin then uses a vendored windows-sdk and clang toolchain and modifies the env to set up cross-compilation. This PR disables this feature so we can set up the x86_64_pc_windows_msvc target inside https://github.com/conda-forge/rust-activation-feedstock in general. This feature is only used when compiling from Mac for Windows, which as far as I can tell, no other feedstock currently does.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Contributor

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, note that this will also disable zig cross compiling support.

@0xbe7a
Copy link
Member Author

0xbe7a commented Oct 20, 2023

It looks like there are no downstream users of the zig feature on conga-forge either. I can re-enable it, however cargo-zigbuild also makes a lot of changes to your build environment and I would rather enable proper support later if the need arises and disable it for now.

@messense
Copy link
Contributor

would rather enable proper support later if the need arises and disable it for now.

Sounds good to me.

@messense messense added the automerge Merge the PR when CI passes label Oct 22, 2023
@messense messense merged commit fbaf1ec into conda-forge:main Oct 22, 2023
@0xbe7a 0xbe7a deleted the no-cross-compile branch October 23, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants