Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuild for hdf5 1.14.1 #107

Merged
merged 4 commits into from
Aug 18, 2023
Merged

rebuild for hdf5 1.14.1 #107

merged 4 commits into from
Aug 18, 2023

Conversation

minrk
Copy link
Member

@minrk minrk commented Aug 16, 2023

The bot claims that this repo has already been migrated, but no PR was issued. Not sure why it thinks this is the case.

This should get adios2 2.9.1, which has been built with hdf5 1.14.1.

closes conda-forge/adios2-feedstock#78

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@minrk
Copy link
Member Author

minrk commented Aug 16, 2023

Some builds are failing with a test timeout:

6/9 Test #6: Asynchronous.10_streaming ........***Timeout 1500.10 sec
Current iteration: 0

while the mac arm+openmpi builds are failing at FindHDF5 in cmake. Not sure why, because the error isn't actually shown. I'm not sure what's different about hdf5 1.14 vs 1.12 here, but there have been issues with cmake changes in 1.14. But the ones I'm aware of were fixed in 1.14.1, though there may be more.

@ax3l ax3l self-assigned this Aug 17, 2023
@ax3l
Copy link
Member

ax3l commented Aug 17, 2023

@franzpoeschel interesting that a series of streaming tests times out. I will restart (linux_64 w/ MPICH; osx x64 w/ MPICH and osx arm64 w/ OpenMPI):

6/9 Test #6: Asynchronous.10_streaming ........***Timeout 1500.08 sec
Current iteration: 0

@franzpoeschel
Copy link

For MPICH builds, this PR should fix the hangups

Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Min and Franz! :)

@ax3l ax3l added the dependencies Concerns recipe dependencies label Aug 18, 2023
@ax3l
Copy link
Member

ax3l commented Aug 18, 2023

Argh, macOS arm64:

-- Found HDF5: $PREFIX/lib/libhdf5.dylib (found version "") found components: C 
CMake Error at CMakeLists.txt:373 (message):
  Found HDF5 version is too old.  At least version 1.8.13 is required.

  If you manually installed a version of HDF5 in a non-default path, add its
  installation prefix to the environment variable CMAKE_PREFIX_PATH to find
  it: https://cmake.org/cmake/help/latest/envvar/CMAKE_PREFIX_PATH.html

Looks like CMake cannot find the HDF5 version for this particular CF build.

I thought I already patched this broken version check out in 0.14.0+:
openPMD/openPMD-api#1027

But it looks like HDF5_VERSION is unset for some reason on macOS arm64 on CF:
https://github.com/openPMD/openPMD-api/blob/0.15.1/CMakeLists.txt#L337C26-L337C38

@ax3l ax3l merged commit 5009bee into conda-forge:main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Concerns recipe dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.9.0 not picked up in openPMD-api
3 participants