Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ptxcompiler Python 3.10 migration never sent #1546

Open
jakirkham opened this issue Aug 18, 2022 · 6 comments
Open

ptxcompiler Python 3.10 migration never sent #1546

jakirkham opened this issue Aug 18, 2022 · 6 comments

Comments

@jakirkham
Copy link
Contributor

jakirkham commented Aug 18, 2022

The ptxcompiler feedstock appears not to have gotten a Python 3.10 migration PR. So submitted one manually ( conda-forge/ptxcompiler-feedstock#13 ). It shows up in the "Done" list for the Python 3.10 migration. Though there does not appear to be a PR associated.

There have been other successful migrations of ptxcompiler. In the bot data for ptxcompiler, do see this entry where it appears the migration PR for Python 3.10 was closed, but maybe do some kind of unexpected event?

@jakirkham
Copy link
Contributor Author

cc @bdice @gmarkall (for awareness)

@jakirkham
Copy link
Contributor Author

Any thoughts on this one?

@beckermr
Copy link
Contributor

I'd add the file manually and rerender to see what happens.

@jakirkham
Copy link
Contributor Author

Yep that's what we did. More want to make sure that other bot PRs are not getting missing.

@minrk
Copy link
Contributor

minrk commented Aug 16, 2023

FWIW, this happened recently with openpmd-api being skipped and added to the done list for hdf51141 without ever getting a PR. I don't understand enough about the bot to try to dig into what incorrect signal is causing it to think the migration is done. A manual add and rerender went just fine: conda-forge/openpmd-api-feedstock#107

@beckermr
Copy link
Contributor

The bot will skip migrations where it adds the migrator and rerenders but nothing changes. The bot will also not send migrations where the solver checks do not pass. You can get info on that from the status page.

IDK what happened here and so if none of these happened, then it is a real bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants